From: Kevin Wolf <kwolf@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Eric Blake <eblake@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Hanna Reitz <hreitz@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [PATCH 2/5] qemu-nbd: fix regression with qemu-nbd --fork run over ssh
Date: Mon, 14 Aug 2023 16:14:41 +0200 [thread overview]
Message-ID: <ZNo20bIZCRjypsIN@redhat.com> (raw)
In-Reply-To: <20230717145544.194786-3-den@openvz.org>
Am 17.07.2023 um 16:55 hat Denis V. Lunev geschrieben:
> Commit e6df58a5578fee7a50bbf36f4a50a2781cff855d
> Author: Hanna Reitz <hreitz@redhat.com>
> Date: Wed May 8 23:18:18 2019 +0200
> qemu-nbd: Do not close stderr
> has introduced an interesting regression. Original behavior of
> ssh somehost qemu-nbd /home/den/tmp/file -f raw --fork
> was the following:
> * qemu-nbd was started as a daemon
> * the command execution is done and ssh exited with success
>
> The patch has changed this behavior and 'ssh' command now hangs forever.
>
> According to the normal specification of the daemon() call, we should
> endup with STDERR pointing to /dev/null. That should be done at the
> very end of the successful startup sequence when the pipe to the
> bootstrap process (used for diagnostics) is no longer needed.
>
> This could be achived in the same way as done for 'qemu-nbd -c' case.
> That was commit 0eaf453e, also fixing up e6df58a5. STDOUT copying to
> STDERR does the trick.
>
> This also leads to proper 'ssh' connection closing which fixes my
> original problem.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> CC: Hanna Reitz <hreitz@redhat.com>
> CC: <qemu-stable@nongnu.org>
This broke qemu-iotests 233 (Eric, please make sure to run the full
qemu-iotests suite before sending block related pull requests):
--- /home/kwolf/source/qemu/tests/qemu-iotests/233.out
+++ /home/kwolf/source/qemu/build-clang/scratch/raw-file-233/233.out.bad
@@ -99,14 +99,4 @@
qemu-nbd: TLS handshake failed: The TLS connection was non-properly terminated.
== final server log ==
-qemu-nbd: option negotiation failed: Failed to read opts magic: Cannot read from TLS channel: Software caused connection abort
-qemu-nbd: option negotiation failed: Failed to read opts magic: Cannot read from TLS channel: Software caused connection abort
-qemu-nbd: option negotiation failed: Verify failed: No certificate was found.
-qemu-nbd: option negotiation failed: Verify failed: No certificate was found.
-qemu-nbd: option negotiation failed: TLS x509 authz check for DISTINGUISHED-NAME is denied
-qemu-nbd: option negotiation failed: TLS x509 authz check for DISTINGUISHED-NAME is denied
-qemu-nbd: option negotiation failed: Failed to read opts magic: Cannot read from TLS channel: Software caused connection abort
-qemu-nbd: option negotiation failed: Failed to read opts magic: Cannot read from TLS channel: Software caused connection abort
-qemu-nbd: option negotiation failed: TLS handshake failed: An illegal parameter has been received.
-qemu-nbd: option negotiation failed: TLS handshake failed: An illegal parameter has been received.
*** done
Do we really want to lose these error messages? This looks wrong to me.
Kevin
next prev parent reply other threads:[~2023-08-14 14:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 14:55 [PATCH v2 0/5] qemu-nbd: fix regression with qemu-nbd --fork run over ssh Denis V. Lunev
2023-07-17 14:55 ` [PATCH 1/5] qemu-nbd: pass structure into nbd_client_thread instead of plain char* Denis V. Lunev
2023-07-17 18:56 ` Eric Blake
2023-07-17 14:55 ` [PATCH 2/5] qemu-nbd: fix regression with qemu-nbd --fork run over ssh Denis V. Lunev
2023-07-17 19:04 ` Eric Blake
2023-07-17 20:26 ` Denis V. Lunev
2023-08-14 14:14 ` Kevin Wolf [this message]
2023-08-15 10:40 ` Denis V. Lunev
2023-08-15 12:17 ` Denis V. Lunev
2023-08-15 14:59 ` Kevin Wolf
2023-08-15 15:21 ` Peter Maydell
2023-08-15 16:08 ` Eric Blake
2023-07-17 14:55 ` [PATCH 3/5] qemu-nbd: properly report error on error in dup2() after qemu_daemon() Denis V. Lunev
2023-07-18 17:45 ` Eric Blake
2023-07-17 14:55 ` [PATCH 4/5] qemu-nbd: properly report error if qemu_daemon() is failed Denis V. Lunev
2023-07-18 17:50 ` Eric Blake
2023-07-17 14:55 ` [PATCH 5/5] qemu-nbd: handle dup2() error when qemu-nbd finished setup process Denis V. Lunev
2023-07-18 17:52 ` Eric Blake
2023-07-17 20:25 ` [PATCH 6/5] qemu-nbd: make verbose bool and local variable in main() Denis V. Lunev
2023-07-18 17:53 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNo20bIZCRjypsIN@redhat.com \
--to=kwolf@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.