From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-renesas-soc@vger.kernel.org,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 RESEND 2/2] PCI: rcar-host: add support for optional regulators
Date: Wed, 16 Aug 2023 11:51:13 +0200 [thread overview]
Message-ID: <ZNycEWhT7a7llUSZ@shikoro> (raw)
In-Reply-To: <20230713153401.GA317502@bhelgaas>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On Thu, Jul 13, 2023 at 10:34:01AM -0500, Bjorn Helgaas wrote:
> On Wed, Jul 12, 2023 at 12:39:16PM +0200, Wolfram Sang wrote:
> > The KingFisher board has regulators. They just need to be en-/disabled,
> > so we can leave the handling to devm. Order variables in reverse-xmas
> > while we are here.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Krzysztof or Lorenzo may fix this up for you, but:
> s/add support/Add support/ in subject to match history
> and recast commit log to say what the patch *does* ("enable optional
> regulators using devm, so devm will automatically disable them when
> the driver releases the device"), not *what needs to be done*.
I will fix the commit messages and resend. But frankly, except the
latter is a tad more explicit, they both qualify for "what needs to be
done" for me *shrug* Still, thanks for the review, I appreciate it!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-08-16 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 10:39 [PATCH v3 RESEND 0/2] KingFisher: support regulators for PCIe Wolfram Sang
2023-07-12 10:39 ` [PATCH v3 RESEND 1/2] dt-bindings: PCI: rcar-pci-host: add optional regulators Wolfram Sang
2023-07-12 10:39 ` [PATCH v3 RESEND 2/2] PCI: rcar-host: add support for " Wolfram Sang
2023-07-13 15:34 ` Bjorn Helgaas
2023-08-16 9:51 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNycEWhT7a7llUSZ@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.