From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH 1/8] kbuild: do not run depmod for 'make modules_sign'
Date: Wed, 23 Aug 2023 21:52:56 +0200 [thread overview]
Message-ID: <ZOZjmLPxwWik/YOz@bergen.fjasle.eu> (raw)
In-Reply-To: <20230823115048.823011-1-masahiroy@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
On Wed 23 Aug 2023 20:50:41 GMT, Masahiro Yamada wrote:
> Commit 961ab4a3cd66 ("kbuild: merge scripts/Makefile.modsign to
> scripts/Makefile.modinst") started to run depmod at the end of
> 'make modules_sign'.
>
> Move the depmod rule to scripts/Makefile.modinst and run it only when
> $(modules_sign_only) is empty.
Moving the depmod rule is in patch 3/8, first half of the sentence
seems to be left over?
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
>
> Fixes: 961ab4a3cd66 ("kbuild: merge scripts/Makefile.modsign to scripts/Makefile.modinst")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index e0d52539a0f1..7d54a0700c6e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1877,7 +1877,9 @@ quiet_cmd_depmod = DEPMOD $(MODLIB)
>
> modules_install:
> $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modinst
> +ifndef modules_sign_only
> $(call cmd,depmod)
> +endif
>
> else # CONFIG_MODULES
>
> --
> 2.39.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-08-23 20:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 11:50 [PATCH 1/8] kbuild: do not run depmod for 'make modules_sign' Masahiro Yamada
2023-08-23 11:50 ` [PATCH 2/8] kbuild: add modules_sign to no-{compiler,sync-config}-targets Masahiro Yamada
2023-08-23 19:53 ` Nicolas Schier
2023-08-23 11:50 ` [PATCH 3/8] kbuild: move depmod rule to scripts/Makefile.modinst Masahiro Yamada
2023-08-23 19:53 ` Nicolas Schier
2023-08-26 13:50 ` Masahiro Yamada
2023-08-23 11:50 ` [PATCH 4/8] kbuild: remove $(MODLIB)/source symlink Masahiro Yamada
2023-08-23 20:17 ` Nicolas Schier
2023-08-23 11:50 ` [PATCH 5/8] kbuild: reduce the number of mkdir calls during modules_install Masahiro Yamada
2023-08-23 20:22 ` Nicolas Schier
2023-08-23 11:50 ` [PATCH 6/8] kbuild: move more module installation code to scripts/Makefile.modinst Masahiro Yamada
2023-08-28 14:25 ` Nicolas Schier
2023-08-29 2:35 ` Masahiro Yamada
2023-08-29 3:50 ` Nicolas Schier
2023-08-23 11:50 ` [PATCH 7/8] kbuild: support 'make modules_sign' with CONFIG_MODULE_SIG_ALL=n Masahiro Yamada
2023-08-28 14:31 ` Nicolas Schier
2023-08-23 11:50 ` [PATCH 8/8] kbuild: support modules_sign for external modules as well Masahiro Yamada
2023-08-28 14:52 ` Nicolas Schier
2023-08-23 19:52 ` Nicolas Schier [this message]
2023-08-26 13:36 ` [PATCH 1/8] kbuild: do not run depmod for 'make modules_sign' Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOZjmLPxwWik/YOz@bergen.fjasle.eu \
--to=nicolas@fjasle.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.