From: Jiri Olsa <olsajiri@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>
Subject: Re: [PATCHv2 bpf] selftests/bpf: Fix kprobe_multi_test/attach_override test
Date: Thu, 14 Sep 2023 08:31:44 +0200 [thread overview]
Message-ID: <ZQKo0Dilcf+Ur/QP@krava> (raw)
In-Reply-To: <CAEf4Bza6GiLXgB1mmo7jUcQPT4PW+tCRTQ266bZ706cqG7sOSg@mail.gmail.com>
On Wed, Sep 13, 2023 at 11:43:47AM -0700, Andrii Nakryiko wrote:
> On Wed, Sep 13, 2023 at 4:47 AM Jiri Olsa <jolsa@kernel.org> wrote:
> >
> > We need to deny the attach_override test for arm64, denying the
> > whole kprobe_multi_test suite. Also making attach_override static.
> >
> > Fixes: 7182e56411b9 ("selftests/bpf: Add kprobe_multi override test")
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> > tools/testing/selftests/bpf/DENYLIST.aarch64 | 9 +--------
> > .../testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
> > 2 files changed, 2 insertions(+), 9 deletions(-)
> >
> > v2 changes:
> > - rebased on latest bpf/master, used just kprobe_multi_test suite name
> > in DENYLIST.aarch64 to cover all kprobe_multi tests
> >
> > diff --git a/tools/testing/selftests/bpf/DENYLIST.aarch64 b/tools/testing/selftests/bpf/DENYLIST.aarch64
> > index 7f768d335698..b733ce16c0f8 100644
> > --- a/tools/testing/selftests/bpf/DENYLIST.aarch64
> > +++ b/tools/testing/selftests/bpf/DENYLIST.aarch64
> > @@ -1,14 +1,7 @@
> > bpf_cookie/multi_kprobe_attach_api # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
> > bpf_cookie/multi_kprobe_link_api # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
> > fexit_sleep # The test never returns. The remaining tests cannot start.
> > -kprobe_multi_bench_attach # bpf_program__attach_kprobe_multi_opts unexpected error: -95
>
> did you drop kprobe_multi_bench_attach from DENYLIST intentionally?
> I'll leave it in DENYLIST.aarch64 for now when applying
ugh, no it should stay.. thanks a lot
jirka
>
> > -kprobe_multi_test/attach_api_addrs # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> > -kprobe_multi_test/attach_api_pattern # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> > -kprobe_multi_test/attach_api_syms # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> > -kprobe_multi_test/bench_attach # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> > -kprobe_multi_test/link_api_addrs # link_fd unexpected link_fd: actual -95 < expected 0
> > -kprobe_multi_test/link_api_syms # link_fd unexpected link_fd: actual -95 < expected 0
> > -kprobe_multi_test/skel_api # libbpf: failed to load BPF skeleton 'kprobe_multi': -3
> > +kprobe_multi_test # needs CONFIG_FPROBE
> > module_attach # prog 'kprobe_multi': failed to auto-attach: -95
> > fentry_test/fentry_many_args # fentry_many_args:FAIL:fentry_many_args_attach unexpected error: -524
> > fexit_test/fexit_many_args # fexit_many_args:FAIL:fexit_many_args_attach unexpected error: -524
> > diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > index e05477b210a5..4041cfa670eb 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > @@ -454,7 +454,7 @@ static void test_kprobe_multi_bench_attach(bool kernel)
> > }
> > }
> >
> > -void test_attach_override(void)
> > +static void test_attach_override(void)
> > {
> > struct kprobe_multi_override *skel = NULL;
> > struct bpf_link *link = NULL;
> > --
> > 2.41.0
> >
next prev parent reply other threads:[~2023-09-14 6:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 11:47 [PATCHv2 bpf] selftests/bpf: Fix kprobe_multi_test/attach_override test Jiri Olsa
2023-09-13 18:43 ` Andrii Nakryiko
2023-09-14 6:31 ` Jiri Olsa [this message]
2023-09-13 18:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQKo0Dilcf+Ur/QP@krava \
--to=olsajiri@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.