From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dhruva Gole <d-gole@ti.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Vignesh Raghavendra <vigneshr@ti.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V2] spi: spi-cadence-quadspi: Fix missing unwind goto warnings
Date: Thu, 21 Sep 2023 14:03:05 +0200 [thread overview]
Message-ID: <ZQww+c0JIP/EqsXT@suswa> (raw)
In-Reply-To: <20230919074658.41666-1-d-gole@ti.com>
On Tue, Sep 19, 2023 at 01:16:59PM +0530, Dhruva Gole wrote:
> The following smatch warnings [0] were recently introduced:
>
> drivers/spi/spi-cadence-quadspi.c:1882 cqspi_probe() warn: missing
> unwind goto?
>
> Fix these warnings by releasing dma channel and adding a goto fail probe.
>
> [0] https://lore.kernel.org/all/5e21c351-cd08-443e-8509-aecf242a4da9@kadam.mountain/
Really this should be the Closes: link. I should edit the zero day
bot emails to send the correct link.
That's going to be slightly more complicated than you might assume...
I'm travelling now so I won't do it today.
regards,
dan carpenter
>
> Fixes: 0578a6dbfe75 ("spi: spi-cadence-quadspi: add runtime pm support")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202309140543.03dMbMM5-lkp@intel.com/
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> ---
>
> Link to V1:
> https://lore.kernel.org/all/20230915123103.2493640-1-d-gole@ti.com/
>
next prev parent reply other threads:[~2023-09-21 19:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 7:46 [PATCH V2] spi: spi-cadence-quadspi: Fix missing unwind goto warnings Dhruva Gole
2023-09-21 12:03 ` Dan Carpenter [this message]
2023-09-26 11:21 ` Mark Brown
2023-09-26 11:34 ` Dhruva Gole
2023-09-26 11:40 ` Dhruva Gole
2023-09-26 11:58 ` Mark Brown
2023-09-26 12:19 ` Dhruva Gole
2023-09-26 12:48 ` Mark Brown
2023-09-26 13:13 ` Dhruva Gole
2023-09-26 15:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQww+c0JIP/EqsXT@suswa \
--to=dan.carpenter@linaro.org \
--cc=broonie@kernel.org \
--cc=d-gole@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.