From: Mark Brown <broonie@kernel.org>
To: Dhruva Gole <d-gole@ti.com>
Cc: Vaishnav Achath <vaishnav.a@ti.com>,
linux-spi@vger.kernel.org, vigneshr@ti.com,
linux-kernel@vger.kernel.org, u-kumar1@ti.com
Subject: Re: [PATCH v2] spi: omap2-mcspi: Fix hardcoded reference clock
Date: Tue, 26 Sep 2023 14:00:40 +0200 [thread overview]
Message-ID: <ZRLH6JbEABFrfQMw@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20230926115554.4hpcgnu6wn4uurpy@dhruva>
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
On Tue, Sep 26, 2023 at 05:25:54PM +0530, Dhruva Gole wrote:
> On Sep 26, 2023 at 17:08:12 +0530, Vaishnav Achath wrote:
> > + ctlr->max_speed_hz = mcspi->ref_clk_hz;
> > + ctlr->min_speed_hz = mcspi->ref_clk_hz >> 15;
> nit: Can we improve on previous code by making 15 into a macro?
I'll queue this for CI now, please send an incremental fix for this
style issue with the constant.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-09-26 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 11:38 [PATCH v2] spi: omap2-mcspi: Fix hardcoded reference clock Vaishnav Achath
2023-09-26 11:55 ` Dhruva Gole
2023-09-26 12:00 ` Mark Brown [this message]
2023-09-26 15:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRLH6JbEABFrfQMw@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=d-gole@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=u-kumar1@ti.com \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.