From: Johan Hovold <johan@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: gnss: u-blox: add "reset-gpios" binding
Date: Mon, 16 Oct 2023 15:43:47 +0200 [thread overview]
Message-ID: <ZS0-E_h4I_g7zVIm@hovoldconsulting.com> (raw)
In-Reply-To: <20230921133202.5828-3-wsa+renesas@sang-engineering.com>
On Thu, Sep 21, 2023 at 03:32:00PM +0200, Wolfram Sang wrote:
> Needed to enable this chip on a Renesas KingFisher board.
What is needed? Please make the commit message self-contained.
And what GNSS chip/module is this? This should also be included in the
commit message.
Do you have a link to a datasheet?
None of the u-blox modules I've seen have a reset line so I'd like to
where this came from and how it is intended to be used.
> Description
> copied over from the Mediatek driver which already supports it.
The mediatek driver does not support managing a reset line, but the
binding includes a description of this pin for completeness. Also you
don't seem include any description of the property below (which is fine)
so perhaps you can just drop this sentence.
Johan
next prev parent reply other threads:[~2023-10-16 13:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 13:31 [PATCH v3 0/3] gnss: ubx: updates to support the Renesas KingFisher board Wolfram Sang
2023-09-21 13:31 ` [PATCH v3 1/3] gnss: ubx: use new helper to remove open coded regulator handling Wolfram Sang
2023-09-21 13:32 ` [PATCH v3 2/3] dt-bindings: gnss: u-blox: add "reset-gpios" binding Wolfram Sang
2023-10-16 13:43 ` Johan Hovold [this message]
2023-10-23 6:52 ` Wolfram Sang
2023-11-06 14:14 ` Johan Hovold
2023-09-21 13:32 ` [PATCH v3 3/3] gnss: ubx: add support for the reset gpio Wolfram Sang
2023-10-16 13:55 ` Johan Hovold
2023-10-23 7:09 ` Wolfram Sang
2023-11-06 14:19 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS0-E_h4I_g7zVIm@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.