From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Wei-Shih Lin <frank101417@gmail.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: Add driver for Novatek NT519XX series touchscreen devices
Date: Sun, 29 Oct 2023 03:26:06 +0000 [thread overview]
Message-ID: <ZT3QzhXr8OaOCfx2@google.com> (raw)
In-Reply-To: <20231025082054.1190-3-Weishih_Lin@novatek.com.tw>
Hi Wei-Shih,
On Wed, Oct 25, 2023 at 04:20:54PM +0800, Wei-Shih Lin wrote:
> This patch adds support for Novatek NT519XX series touchscreen devices.
> Existing Novatek touchscreen driver code developed for Acer Iconia One 7
> B1-750 tablet with Novatek IC NT11205 is novatek-nvt-ts.c in the path
> drivers/input/touchscreen/. However, this patch supports touch features
> for automotive display with Novatek TDDI NT519XX.
How different the protocol of this part from NT11205? Can the existing
driver be modified to support both variants?
You already got feedback from Krzysztof, on top of his, if we want to
continue with a separate driver:
- it should use standard device properties
- it should use gpiod API
- it looks like it will benefit of regmap's paging support
- helpers like nvt_irq_enable() should not be used - your code should
know whether itq is enabled or disabled at all times
- all caps are reserved for macros (CTP_I2C_WRITE and others)
- I am sure we have crc8 helpers in the kernel
- please use u8, u16, etc in the kernel code instead of uint8_t,
uint16_t
- your driver will likely benefit from devm APIs
- no compile-time conditionals like "#if TOUCH_MAX_FINGER_NUM > 1"
Thanks.
--
Dmitry
prev parent reply other threads:[~2023-10-29 3:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 8:20 [PATCH 0/2] Add Novatek NT519XX touchcreen driver Wei-Shih Lin
2023-10-25 8:20 ` [PATCH 1/2] dt-bindings: touchscreen: Add Novatek NT519XX series bindings Wei-Shih Lin
2023-10-25 14:25 ` Rob Herring
2023-10-28 8:50 ` Krzysztof Kozlowski
2023-10-25 8:20 ` [PATCH 2/2] Input: Add driver for Novatek NT519XX series touchscreen devices Wei-Shih Lin
2023-10-28 8:52 ` Krzysztof Kozlowski
2023-10-29 3:26 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZT3QzhXr8OaOCfx2@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank101417@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.