From: Wolfram Sang <wsa@kernel.org>
To: linux-renesas-soc@vger.kernel.org
Cc: Yang Yingliang <yangyingliang@huawei.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] i2c: fix memleak in i2c_new_client_device()
Date: Mon, 23 Oct 2023 17:26:16 +0200 [thread overview]
Message-ID: <ZTaQmK2omo6XWbg2@ninjato> (raw)
In-Reply-To: <20230929091952.19957-1-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]
On Fri, Sep 29, 2023 at 11:19:52AM +0200, Wolfram Sang wrote:
> Yang Yingliang reported a memleak:
> ===
>
> I got memory leak as follows when doing fault injection test:
>
> unreferenced object 0xffff888014aec078 (size 8):
> comm "xrun", pid 356, jiffies 4294910619 (age 16.332s)
> hex dump (first 8 bytes):
> 31 2d 30 30 31 63 00 00 1-001c..
> backtrace:
> [<00000000eb56c0a9>] __kmalloc_track_caller+0x1a6/0x300
> [<000000000b220ea3>] kvasprintf+0xad/0x140
> [<00000000b83203e5>] kvasprintf_const+0x62/0x190
> [<000000002a5eab37>] kobject_set_name_vargs+0x56/0x140
> [<00000000300ac279>] dev_set_name+0xb0/0xe0
> [<00000000b66ebd6f>] i2c_new_client_device+0x7e4/0x9a0
>
> If device_register() returns error in i2c_new_client_device(),
> the name allocated by i2c_dev_set_name() need be freed. As
> comment of device_register() says, it should use put_device()
> to give up the reference in the error path.
>
> ===
> I think this solution is less intrusive and more robust than he
> originally proposed solutions, though.
>
> Reported-by: Yang Yingliang <yangyingliang@huawei.com>
> Closes: http://patchwork.ozlabs.org/project/linux-i2c/patch/20221124085448.3620240-1-yangyingliang@huawei.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-10-23 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 9:19 [PATCH v3] i2c: fix memleak in i2c_new_client_device() Wolfram Sang
2023-10-23 15:26 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTaQmK2omo6XWbg2@ninjato \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.