From: Matthew Wilcox <willy@infradead.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH 1/6] mm: ksm: use more folio api in ksm_might_need_to_copy()
Date: Tue, 7 Nov 2023 14:24:22 +0000 [thread overview]
Message-ID: <ZUpIlkO0E7+i2hCg@casper.infradead.org> (raw)
In-Reply-To: <20231107135216.415926-2-wangkefeng.wang@huawei.com>
On Tue, Nov 07, 2023 at 09:52:11PM +0800, Kefeng Wang wrote:
> struct page *ksm_might_need_to_copy(struct page *page,
> - struct vm_area_struct *vma, unsigned long address)
> + struct vm_area_struct *vma, unsigned long addr)
> {
> struct folio *folio = page_folio(page);
> struct anon_vma *anon_vma = folio_anon_vma(folio);
> - struct page *new_page;
> + struct folio *new_folio;
>
> - if (PageKsm(page)) {
> - if (page_stable_node(page) &&
> + if (folio_test_ksm(folio)) {
> + if (folio_stable_node(folio) &&
> !(ksm_run & KSM_RUN_UNMERGE))
> return page; /* no need to copy it */
> } else if (!anon_vma) {
> return page; /* no need to copy it */
> - } else if (page->index == linear_page_index(vma, address) &&
> + } else if (page->index == linear_page_index(vma, addr) &&
Hmm. page->index is going away. What should we do here instead?
The rest of this looks good.
next prev parent reply other threads:[~2023-11-07 14:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 13:52 [PATCH 0/6] mm: cleanup and use more folio in page fault Kefeng Wang
2023-11-07 13:52 ` [PATCH 1/6] mm: ksm: use more folio api in ksm_might_need_to_copy() Kefeng Wang
2023-11-07 14:24 ` Matthew Wilcox [this message]
2023-11-08 1:40 ` Kefeng Wang
2023-11-08 13:59 ` Matthew Wilcox
2023-11-09 7:09 ` Kefeng Wang
2023-11-13 8:32 ` David Hildenbrand
2023-11-13 9:51 ` Kefeng Wang
2023-11-07 13:52 ` [PATCH 2/6] mm: memory: use a folio in validate_page_before_insert() Kefeng Wang
2023-11-07 18:17 ` Sidhartha Kumar
2023-11-07 13:52 ` [PATCH 3/6] mm: memory: rename page_copy_prealloc() to folio_prealloc() Kefeng Wang
2023-11-07 18:21 ` Sidhartha Kumar
2023-11-07 13:52 ` [PATCH 4/6] mm: memory: use a folio in do_cow_page() Kefeng Wang
2023-11-07 18:27 ` Sidhartha Kumar
2023-11-08 1:41 ` Kefeng Wang
2023-11-07 13:52 ` [PATCH 5/6] mm: memory: use folio_prealloc() in wp_page_copy() Kefeng Wang
2023-11-07 13:52 ` [PATCH 6/6] mm: memory: use folio_prealloc() in do_anonymous_page() Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUpIlkO0E7+i2hCg@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.