From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: "Conor Dooley" <conor.dooley@microchip.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Joel Stanley" <joel@jms.id.au>,
"Walker Chen" <walker.chen@starfivetech.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Huisong Li" <lihuisong@huawei.com>,
"Arnd Bergmann" <arnd@arndb.de>, "Wei Xu" <xuwei5@hisilicon.com>,
"Emil Renner Berthing" <kernel@esmil.dk>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
"Hal Feng" <hal.feng@starfivetech.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 08/40] soc: Add SoC driver for Cirrus ep93xx
Date: Wed, 13 Dec 2023 20:37:10 +0200 [thread overview]
Message-ID: <ZXn51mcYslZzQ3y-@smile.fi.intel.com> (raw)
In-Reply-To: <20231212-ep93xx-v6-8-c307b8ac9aa8@maquefel.me>
On Tue, Dec 12, 2023 at 11:20:25AM +0300, Nikita Shubin wrote:
> Add an SoC driver for the ep93xx. Currently there is only one thing
> not fitting into any other framework, and that is the swlock setting.
...
> +/*
> + * SoC driver for Cirrus EP93xx chips.
> + * Copyright (C) 2022 Nikita Shubin <nikita.shubin@maquefel.me>
> + *
> + * Based on a rewrite of arch/arm/mach-ep93xx/core.c
> + * Copyright (C) 2006 Lennert Buytenhek <buytenh@wantstofly.org>
> + * Copyright (C) 2007 Herbert Valerio Riedel <hvr@gnu.org>
> + *
> + * Thanks go to Michael Burian and Ray Lehtiniemi for their key
> + * role in the ep93xx Linux community
Missing period.
> + */
...
> +#include <linux/bits.h>
> +#include <linux/init.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/of.h>
> +#include <linux/of_fdt.h>
> +#include <linux/platform_device.h>
Isn't this an incorrect header and should be auxiliary one?
> +#include <linux/regmap.h>
> +#include <linux/slab.h>
+ spinlock.h ?
But since it's a new code, why not cleanup.h?
> +#include <linux/sys_soc.h>
...
> + enum ep93xx_soc_model model = (int)(uintptr_t)of_device_get_match_data(&pdev->dev);
int?
Maybe
strict device *dev = &pdev->dev;
enum ep93xx_soc_model model;
...
model = (enum ep93xx_soc_model)(uintptr_t)device_get_match_data(dev);
?
...
> + struct device *dev = &pdev->dev;
Ah you even have this already!
...
> + dev_info(dev, "EP93xx SoC revision %s\n", attrs->revision);
Hmm... Is this message anyhow useful?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-13 18:37 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 8:20 [PATCH v6 00/40] ep93xx device tree conversion Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 01/40] ARM: ep93xx: Add terminator to gpiod_lookup_table Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-13 17:24 ` Andy Shevchenko
2023-12-13 17:24 ` Andy Shevchenko
2023-12-12 8:20 ` [PATCH v6 02/40] gpio: ep93xx: split device in multiple Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 03/40] ARM: ep93xx: add regmap aux_dev Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 17:28 ` Andy Shevchenko
2023-12-12 8:20 ` [PATCH v6 04/40] clk: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 17:42 ` Andy Shevchenko
2023-12-23 8:35 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 05/40] pinctrl: add a Cirrus ep93xx SoC pin controller Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 17:51 ` Andy Shevchenko
2023-12-23 8:55 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 06/40] power: reset: Add a driver for the ep93xx reset Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 17:54 ` Andy Shevchenko
2023-12-12 8:20 ` [PATCH v6 07/40] dt-bindings: soc: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 6:53 ` Krzysztof Kozlowski
2023-12-12 8:20 ` [PATCH v6 08/40] soc: Add SoC driver for Cirrus ep93xx Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 18:37 ` Andy Shevchenko [this message]
2023-12-23 10:06 ` Nikita Shubin
2023-12-23 11:32 ` Arnd Bergmann
2023-12-12 8:20 ` [PATCH v6 09/40] dt-bindings: dma: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 10/40] dma: cirrus: Convert to DT for " Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 18:28 ` Andy Shevchenko
2023-12-12 8:20 ` [PATCH v6 11/40] dt-bindings: watchdog: Add Cirrus EP93x Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 12/40] watchdog: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 17:56 ` Andy Shevchenko
2023-12-12 8:20 ` [PATCH v6 13/40] dt-bindings: pwm: Add " Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 14/40] pwm: ep93xx: add DT support for " Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 17:56 ` Andy Shevchenko
2023-12-12 8:20 ` [PATCH v6 15/40] dt-bindings: spi: Add " Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 16/40] spi: ep93xx: add DT support for " Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 18:13 ` Andy Shevchenko
2023-12-12 8:20 ` [PATCH v6 17/40] dt-bindings: net: Add " Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 18/40] net: cirrus: add DT support for " Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 18:39 ` Andy Shevchenko
2023-12-12 8:20 ` [PATCH v6 19/40] dt-bindings: mtd: Add ts7200 nand-controller Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 20/40] mtd: rawnand: add support for ts72xx Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-12 8:30 ` Greg Kroah-Hartman
2023-12-12 8:30 ` Greg Kroah-Hartman
2023-12-12 8:35 ` Nikita Shubin
2023-12-12 8:35 ` Nikita Shubin
2023-12-12 14:05 ` Miquel Raynal
2023-12-12 14:05 ` Miquel Raynal
2023-12-15 10:16 ` Miquel Raynal
2023-12-15 10:16 ` Miquel Raynal
2023-12-15 12:11 ` Nikita Shubin
2023-12-15 12:11 ` Nikita Shubin
2023-12-15 12:27 ` Miquel Raynal
2023-12-15 12:27 ` Miquel Raynal
2023-12-12 8:20 ` [PATCH v6 21/40] dt-bindings: ata: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 22/40] ata: pata_ep93xx: add device tree support Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 18:19 ` Andy Shevchenko
2023-12-12 8:20 ` [PATCH v6 23/40] dt-bindings: input: Add Cirrus EP93xx keypad Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 24/40] input: keypad: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-13 18:41 ` Andy Shevchenko
2023-12-13 18:41 ` Andy Shevchenko
2023-12-12 8:20 ` [PATCH v6 25/40] dt-bindings: wdt: Add ts72xx Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 15:03 ` Guenter Roeck
2023-12-12 8:20 ` [PATCH v6 26/40] wdt: ts72xx: add DT support for ts72xx Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 18:10 ` Andy Shevchenko
2023-12-12 8:20 ` [PATCH v6 27/40] gpio: ep93xx: add DT support for gpio-ep93xx Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 28/40] ASoC: dt-bindings: ep93xx: Document DMA support Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 29/40] ASoC: dt-bindings: ep93xx: Document Audio Port support Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 30/40] ASoC: ep93xx: Drop legacy DMA support Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 31/40] ARM: dts: add Cirrus EP93XX SoC .dtsi Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 32/40] ARM: dts: ep93xx: add ts7250 board Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 33/40] ARM: dts: ep93xx: Add EDB9302 DT Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 34/40] ARM: ep93xx: DT for the Cirrus ep93xx SoC platforms Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 35/40] pwm: ep93xx: drop legacy pinctrl Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 36/40] ata: pata_ep93xx: remove legacy pinctrl use Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-13 18:16 ` Andy Shevchenko
2023-12-13 18:16 ` Andy Shevchenko
2023-12-13 18:33 ` Uwe Kleine-König
2023-12-13 18:33 ` Uwe Kleine-König
2023-12-13 18:48 ` Andy Shevchenko
2023-12-13 18:48 ` Andy Shevchenko
2023-12-14 10:26 ` Uwe Kleine-König
2023-12-14 10:26 ` Uwe Kleine-König
2023-12-12 8:20 ` [PATCH v6 37/40] ARM: ep93xx: delete all boardfiles Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 38/40] ARM: ep93xx: soc: drop defines Nikita Shubin
2023-12-12 8:20 ` Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 39/40] ASoC: cirrus: edb93xx: Delete driver Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-12 8:20 ` [PATCH v6 40/40] dma: cirrus: remove platform code Nikita Shubin via B4 Relay
2023-12-12 8:20 ` Nikita Shubin
2023-12-13 18:30 ` Andy Shevchenko
2023-12-23 9:49 ` Nikita Shubin
2023-12-12 11:53 ` [PATCH v6 00/40] ep93xx device tree conversion Uwe Kleine-König
2023-12-12 11:53 ` Uwe Kleine-König
2023-12-13 17:59 ` Andy Shevchenko
2023-12-13 17:59 ` Andy Shevchenko
2023-12-23 9:12 ` Nikita Shubin
2023-12-23 9:12 ` Nikita Shubin
2023-12-25 19:55 ` Andy Shevchenko
2023-12-25 19:55 ` Andy Shevchenko
2023-12-27 17:40 [PATCH v6 08/40] soc: Add SoC driver for Cirrus ep93xx Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXn51mcYslZzQ3y-@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=conor.dooley@microchip.com \
--cc=hal.feng@starfivetech.com \
--cc=j.neuschaefer@gmx.net \
--cc=joel@jms.id.au \
--cc=kernel@esmil.dk \
--cc=lihuisong@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=ulf.hansson@linaro.org \
--cc=walker.chen@starfivetech.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.