Re: [PATCH v3 10/10] iio: pressure: mprls0025pa add SPI driver

From: Petre Rodan <petre.rodan@subdimension.ro>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andreas Klinger <ak@it-klinger.de>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Angel Iglesias <ang.iglesiasg@gmail.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v3 10/10] iio: pressure: mprls0025pa add SPI driver
Date: Sat, 6 Jan 2024 18:02:52 +0200	[thread overview]
Message-ID: <ZZl5rBPOKwvxZAAx@sunspire> (raw)
In-Reply-To: <ZZlyDT0J4n1_YXh4@smile.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

hello Andy,

On Sat, Jan 06, 2024 at 05:30:21PM +0200, Andy Shevchenko wrote:
> On Fri, Dec 29, 2023 at 11:24:38AM +0200, Petre Rodan wrote:
> > Add SPI component of the driver.
> 
> > Tested with mprls0015pa0000sa in spi mode on BeagleBone Black on
> > slightly patched 6.7.0-rc6 mainline.
> 
> > Tested with mprls0025pa in i2c mode on BeagleBone Black with togreg
> > branch on
> > git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
> > (tag: iio-for-6.8a)
> 
> I believe these paragraphs can be moved to the patch submission comments from
> the commit message...
> 
> > Tested-by: Andreas Klinger <ak@it-klinger.de>
> > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
> > ---
> > v2 -> v3 removed iio.h include line
> 
> ...somewhere here.
> 
> ...
> 
> > +#include <linux/mod_devicetable.h>
> > +#include <linux/module.h>
> > +#include <linux/spi/spi.h>
> > +#include <linux/stddef.h>
> 
> Basically here we need additionally these ones:
> 
> device.h
> errno.h
> types.h

ok, I'll add errno.h. the other two are in the shared .h file.

cheers,
peter

> (I haven't checked i2c counterpart for the similarities).
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

-- 
petre rodan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]