From: Hangbin Liu <liuhangbin@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, Phil Sutter <phil@nwl.cc>,
David Ahern <dsahern@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v4 1/2] Revert "net: rtnetlink: Enslave device before bringing it up"
Date: Tue, 9 Jan 2024 11:38:37 +0800 [thread overview]
Message-ID: <ZZy_vX_uJgryR-Ti@Laptop-X1> (raw)
In-Reply-To: <20240108094103.2001224-2-nicolas.dichtel@6wind.com>
On Mon, Jan 08, 2024 at 10:41:02AM +0100, Nicolas Dichtel wrote:
> This reverts commit a4abfa627c3865c37e036bccb681619a50d3d93c.
>
> The patch broke:
> > ip link set dummy0 up
> > ip link set dummy0 master bond0 down
>
> This last command is useful to be able to enslave an interface with only
> one netlink message.
>
> After discussion, there is no good reason to support:
> > ip link set dummy0 down
> > ip link set dummy0 master bond0 up
> because the bond interface already set the slave up when it is up.
>
> Cc: stable@vger.kernel.org
> Fixes: a4abfa627c38 ("net: rtnetlink: Enslave device before bringing it up")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
next prev parent reply other threads:[~2024-01-09 3:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 9:41 [PATCH net v4 0/2] rtnetlink: allow to enslave with one msg an up interface Nicolas Dichtel
2024-01-08 9:41 ` [PATCH net v4 1/2] Revert "net: rtnetlink: Enslave device before bringing it up" Nicolas Dichtel
2024-01-08 10:29 ` Jiri Pirko
2024-01-09 3:38 ` Hangbin Liu [this message]
2024-01-08 9:41 ` [PATCH net v4 2/2] selftests: rtnetlink: check enslaving iface in a bond Nicolas Dichtel
2024-01-08 10:31 ` Jiri Pirko
2024-01-12 1:15 ` Hangbin Liu
2024-01-12 8:06 ` Nicolas Dichtel
2024-01-12 9:38 ` Hangbin Liu
2024-01-12 1:00 ` [PATCH net v4 0/2] rtnetlink: allow to enslave with one msg an up interface patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZy_vX_uJgryR-Ti@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=phil@nwl.cc \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.