From: Johan Hovold <johan@kernel.org>
To: Rob Winn <rob.winn@integrelsolutions.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: USB: serial: cp210x: Add VID/PID for Integrel Solutions OEG Controller
Date: Tue, 30 Jan 2024 15:57:17 +0100 [thread overview]
Message-ID: <ZbkOTUoQkC7CJ8A9@hovoldconsulting.com> (raw)
In-Reply-To: <CWLP123MB6443E84799CC3972B5317E589A722@CWLP123MB6443.GBRP123.PROD.OUTLOOK.COM>
On Wed, Jan 17, 2024 at 11:03:20PM +0000, Rob Winn wrote:
> Add vid/pid combination for Integrel Solutions OEG Controller to cp210x driver
Please wrap the commit message at 72 columns.
> Signed-off-by: Robert Winn <rob.winn@integrelsolutions.com>
Nit: You From line should ideally match you SoB (e.g. use Robert in
both).
> ---
> drivers/usb/serial/cp210x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index 1e61fe043..d1f993eea 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -163,6 +163,7 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x10C4, 0x8A5B) }, /* CEL EM3588 ZigBee USB Stick */
> { USB_DEVICE(0x10C4, 0x8A5E) }, /* CEL EM3588 ZigBee USB Stick Long Range */
> { USB_DEVICE(0x10C4, 0x8B34) }, /* Qivicon ZigBee USB Radio Stick */
> + { USB_DEVICE(0x10C4, 0x8DDC) }, /* Integrel Solutions Integrel OEG Controller */
Stray second "Integrel"?
> { USB_DEVICE(0x10C4, 0xEA60) }, /* Silicon Labs factory default */
> { USB_DEVICE(0x10C4, 0xEA61) }, /* Silicon Labs factory default */
> { USB_DEVICE(0x10C4, 0xEA63) }, /* Silicon Labs Windows Update (CP2101-4/CP2102N) */
>
And the patch appears to be whitespace damaged (tabs replaced with
spaces).
Make sure you can send the patch to yourself (and apply it successfully)
before resending.
Johan
prev parent reply other threads:[~2024-01-30 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 23:03 USB: serial: cp210x: Add VID/PID for Integrel Solutions OEG Controller Rob Winn
2024-01-30 14:57 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbkOTUoQkC7CJ8A9@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rob.winn@integrelsolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.