From: Jiri Olsa <olsajiri@gmail.com>
To: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Mykola Lysenko <mykolal@fb.com>, Rong Tao <rongtao@cestc.cn>
Subject: Re: [PATCH bpf] selftests/bpf: trace_helpers.c: do not use poisoned type
Date: Fri, 2 Feb 2024 14:18:36 +0100 [thread overview]
Message-ID: <ZbzrrBKaJyRJLEz8@krava> (raw)
In-Reply-To: <20240202095559.12900-1-shung-hsi.yu@suse.com>
On Fri, Feb 02, 2024 at 05:55:58PM +0800, Shung-Hsi Yu wrote:
> After commit c698eaebdf47 ("selftests/bpf: trace_helpers.c: Optimize
> kallsyms cache") trace_helpers.c now includes libbpf_internal.h, and
> thus can no longer use the u32 type (among others) since they are poison
> in libbpf_internal.h. Replace u32 with __u32 to fix the following error
> when building trace_helpers.c on powerpc:
>
> error: attempt to use poisoned "u32"
>
> Fixes: c698eaebdf47 ("selftests/bpf: trace_helpers.c: Optimize kallsyms cache")
> Signed-off-by: Shung-Hsi Yu <shung-hsi.yu@suse.com>
> ---
> Somehow this error only shows up when I'm building on ppc64le, but not
> x86_64 and aarch64. But I didn't investigate further.
it's within powerpc ifdef:
#if defined(__powerpc64__) && defined(_CALL_ELF) && _CALL_ELF == 2
Acked-by: Jiri Olsa <jolsa@kernel.org>
jirka
> ---
> tools/testing/selftests/bpf/trace_helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/trace_helpers.c b/tools/testing/selftests/bpf/trace_helpers.c
> index 4faa898ff7fc..27fd7ed3e4b0 100644
> --- a/tools/testing/selftests/bpf/trace_helpers.c
> +++ b/tools/testing/selftests/bpf/trace_helpers.c
> @@ -271,7 +271,7 @@ ssize_t get_uprobe_offset(const void *addr)
> * addi r2,r2,XXXX
> */
> {
> - const u32 *insn = (const u32 *)(uintptr_t)addr;
> + const __u32 *insn = (const __u32 *)(uintptr_t)addr;
>
> if ((((*insn & OP_RT_RA_MASK) == ADDIS_R2_R12) ||
> ((*insn & OP_RT_RA_MASK) == LIS_R2)) &&
>
> base-commit: 943b043aeecce9accb6d367af47791c633e95e4d
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-02-02 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 9:55 [PATCH bpf] selftests/bpf: trace_helpers.c: do not use poisoned type Shung-Hsi Yu
2024-02-02 13:18 ` Jiri Olsa [this message]
2024-02-02 22:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbzrrBKaJyRJLEz8@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=rongtao@cestc.cn \
--cc=sdf@google.com \
--cc=shung-hsi.yu@suse.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.