Re: [PATCH 4.19.y-cip] ravb: remove undocumented counter processing

From: Pavel Machek <pavel@denx.de>
To: nobuhiro1.iwamatsu@toshiba.co.jp
Cc: pavel@denx.de, biju.das.jz@bp.renesas.com,
	cip-dev@lists.cip-project.org,
	prabhakar.mahadev-lad.rj@bp.renesas.com,
	horms+renesas@verge.net.au, davem@davemloft.net
Subject: Re: [PATCH 4.19.y-cip] ravb: remove undocumented counter processing
Date: Wed, 7 Feb 2024 11:21:46 +0100	[thread overview]
Message-ID: <ZcNZughHMqPLI0rG@duo.ucw.cz> (raw)
In-Reply-To: <OS0PR01MB63888FB4C816903105B925E792462@OS0PR01MB6388.jpnprd01.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

Hi!

> > > commit 009a470365b37106bbd66f1e1a53bc6c3c0072bc upstream.
> > >
> > > This patch removes the use of the undocumented counter registers CDCR,
> > > LCCR, CERCR, CEECR.
> > >
> > > Offsets used for undocumented registers are considered reserved and
> > > should not be written to. After some internal investigation with
> > > Renesas it remains unclear why this driver accesses these fields but
> > > regardless of what the historical reasons are the current code is considered
> > incorrect.
> > >
> > > Based on work by Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> > >
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > > Signed-off-by: David S. Miller <davem@davemloft.net>
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > 
> > This looks okay to me, I can apply it to 4.4/4.19 if it passes testing and if there
> > are no other comments.
> 
> Looks good to me, too.
> Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Thank you. 4.4/4.19 passed testing, so I'm pushing both trees.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]