From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Paul Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/5] iommu/x86: fix IVMD/RMRR range checker loop increment
Date: Wed, 14 Feb 2024 13:04:12 +0100 [thread overview]
Message-ID: <ZcysPDDHvkEuFrgJ@macbook> (raw)
In-Reply-To: <b2433393-1a04-4570-abe6-0356db9976f8@suse.com>
On Wed, Feb 14, 2024 at 12:51:36PM +0100, Jan Beulich wrote:
> On 14.02.2024 11:37, Roger Pau Monne wrote:
> > mfn_add() doesn't store the incremented value in the parameter, and instead
> > returns it to the caller. As a result, the loop in iommu_unity_region_ok()
> > didn't make progress. Fix it by storing the incremented value.
> >
> > Fixes: e45801dea17b ('iommu/x86: introduce a generic IVMD/RMRR range validity helper')
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> Should Andrew get a Reported-by here? And surely we want to list the
> Coverity ID as well? (Happy to take of both while committing, so long
> as you agree.)
Oh, I didn't add those here, yes, sure, feel free to add.
Thanks, Roger.
next prev parent reply other threads:[~2024-02-14 12:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 10:37 [PATCH 0/5] Fix fallout from IVMD/RMRR unification checks Roger Pau Monne
2024-02-14 10:37 ` [PATCH 1/5] iommu/x86: fix IVMD/RMRR range checker loop increment Roger Pau Monne
2024-02-14 11:51 ` Jan Beulich
2024-02-14 12:04 ` Roger Pau Monné [this message]
2024-02-14 10:37 ` [PATCH 2/5] iommu/x86: print RMRR/IVMD ranges using full addresses Roger Pau Monne
2024-02-14 13:22 ` Jan Beulich
2024-02-14 14:03 ` Roger Pau Monné
2024-02-14 10:37 ` [PATCH 3/5] iommu/x86: use full addresses internally for the IVMD/RMRR range checks Roger Pau Monne
2024-02-14 13:29 ` Jan Beulich
2024-02-14 14:05 ` Roger Pau Monné
2024-02-14 14:31 ` Jan Beulich
2024-02-14 10:37 ` [PATCH 4/5] iommu/x86: print page type in IVMD/RMRR check in case of error Roger Pau Monne
2024-02-14 13:30 ` Jan Beulich
2024-02-14 10:37 ` [PATCH 5/5] mm: add the __must_check attribute to {gfn,mfn}_add() Roger Pau Monne
2024-02-14 12:02 ` Julien Grall
2024-02-14 13:42 ` Jan Beulich
2024-02-14 14:00 ` Roger Pau Monné
2024-02-14 14:11 ` [PATCH v2 5/5] mm: add the __must_check attribute to {gfn,mfn,dfn}_add() Roger Pau Monne
2024-02-14 14:32 ` Jan Beulich
2024-02-19 5:07 ` [PATCH 5/5] mm: add the __must_check attribute to {gfn,mfn}_add() George Dunlap
2024-02-19 8:50 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcysPDDHvkEuFrgJ@macbook \
--to=roger.pau@citrix.com \
--cc=jbeulich@suse.com \
--cc=paul@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.