From: Christoph Hellwig <hch@infradead.org>
To: Marios Makassikis <mmakassikis@freebox.fr>
Cc: linux-cifs@vger.kernel.org
Subject: Re: [PATCH 2/2] ksmbd: retrieve number of blocks using vfs_getattr in set_file_allocation_info
Date: Tue, 20 Feb 2024 22:44:56 -0800 [thread overview]
Message-ID: <ZdWb6AlGj4qqcCHn@infradead.org> (raw)
In-Reply-To: <20240220142601.3624584-2-mmakassikis@freebox.fr>
On Tue, Feb 20, 2024 at 03:26:01PM +0100, Marios Makassikis wrote:
> Use vfs_getattr() as inode->i_blocks may be 0 on some filesystems (XFS
> for example).
Same comment as for patch 1. The code changes also look good to me.
next prev parent reply other threads:[~2024-02-21 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 14:26 [PATCH 1/2] ksmbd: replace generic_fillattr with vfs_getattr Marios Makassikis
2024-02-20 14:26 ` [PATCH 2/2] ksmbd: retrieve number of blocks using vfs_getattr in set_file_allocation_info Marios Makassikis
2024-02-21 6:44 ` Christoph Hellwig [this message]
2024-02-21 16:34 ` Namjae Jeon
2024-02-21 6:44 ` [PATCH 1/2] ksmbd: replace generic_fillattr with vfs_getattr Christoph Hellwig
2024-02-21 16:33 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdWb6AlGj4qqcCHn@infradead.org \
--to=hch@infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=mmakassikis@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.