From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, ang.iglesiasg@gmail.com,
linus.walleij@linaro.org, semen.protsenko@linaro.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers: iio: pressure: Fixes BMP38x and BMP390 SPI support
Date: Wed, 21 Feb 2024 15:21:43 +0200 [thread overview]
Message-ID: <ZdX45xqSlz1oQQ-R@smile.fi.intel.com> (raw)
In-Reply-To: <20240220224329.53729-2-vassilisamir@gmail.com>
On Tue, Feb 20, 2024 at 11:43:29PM +0100, Vasileios Amoiridis wrote:
> According to the datasheet of BMP38x and BMP390 devices, for an SPI
> read operation the first byte that is returned needs to be dropped,
> and the rest of the bytes are the actual data returned from the
> sensor.
LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
(If you got tags in the previous rounds of review, it's your responsibility
to carry them, in case code is not _drastically_ changed.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-21 13:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 22:43 [PATCH 1/2] drivers: iio: pressure: Sort headers of BMPxxx SPI driver Vasileios Amoiridis
2024-02-20 22:43 ` [PATCH 2/2] drivers: iio: pressure: Fixes BMP38x and BMP390 SPI support Vasileios Amoiridis
2024-02-21 13:21 ` Andy Shevchenko [this message]
2024-02-24 18:01 ` Jonathan Cameron
2024-02-22 7:58 ` Angel Iglesias
2024-02-21 13:20 ` [PATCH 1/2] drivers: iio: pressure: Sort headers of BMPxxx SPI driver Andy Shevchenko
2024-02-22 7:54 ` Angel Iglesias
2024-02-24 18:04 ` Jonathan Cameron
2024-02-24 22:09 ` Vasileios Amoiridis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdX45xqSlz1oQQ-R@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ang.iglesiasg@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.