From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: renesas: Allow the compiler to optimize away sh_pfc_pm
Date: Wed, 21 Feb 2024 15:19:04 +0200 [thread overview]
Message-ID: <ZdX4SFXv53QyF49N@smile.fi.intel.com> (raw)
In-Reply-To: <6238a78e32fa21f0c795406b6cba7bce7af92577.1708513940.git.geert+renesas@glider.be>
On Wed, Feb 21, 2024 at 12:13:59PM +0100, Geert Uytterhoeven wrote:
> The conversion to DEFINE_NOIRQ_DEV_PM_OPS() lost the ability of the
> compiler to optimize away the struct dev_pm_ops object when it is not
> needed.
>
> Fix this by replacing the use of pm_sleep_ptr() by a custom wrapper.
>
> Fixes: 727eb02eb753375e ("pinctrl: renesas: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper")
Is this a new requirement (I mean more than 12 digits of SHA)?
...
> ---
> To be queued in renesas-pinctrl for v6.9.
>
> Alternatively, one could add a unified definition:
>
> #define pm_psci_sleep_ptr(_ptr) PTR_IF(IS_ENABLED(CONFIG_PM_SLEEP) && \
> IS_ENABLED(CONFIG_ARM_PSCI_FW), (_ptr))
>
> Since there are already separate sections for CONFIG_ARM_PSCI_FW enabled
> vs. disabled, I split in two and simplified the definition.
I'm fine with current approach, IIUC we discussed this that time and the
727eb02eb753 was not the first version (or I can be mistaken, I don't remember
exact driver that the discussion was about during the DEFINE_NOIRQ_DEV_PM_OPS()
conversions).
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-21 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 11:13 [PATCH] pinctrl: renesas: Allow the compiler to optimize away sh_pfc_pm Geert Uytterhoeven
2024-02-21 13:19 ` Andy Shevchenko [this message]
2024-02-21 13:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdX4SFXv53QyF49N@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.