Re: [PATCH v3 4/4] of: property: fw_devlink: Add support for "post-init-providers" property

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Saravana Kannan <saravanak@google.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Len Brown <lenb@kernel.org>,
	kernel-team@android.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH v3 4/4] of: property: fw_devlink: Add support for "post-init-providers" property
Date: Thu, 22 Feb 2024 15:32:48 +0200	[thread overview]
Message-ID: <ZddNAHqwCNR5MZc4@smile.fi.intel.com> (raw)
In-Reply-To: <20240221233026.2915061-5-saravanak@google.com>

On Wed, Feb 21, 2024 at 03:30:24PM -0800, Saravana Kannan wrote:
> Add support for this property so that dependency cycles can be broken and
> fw_devlink can do better probe/suspend/resume ordering between devices in a
> dependency cycle.

...

> -	fwnode_link_add(of_fwnode_handle(con_np), of_fwnode_handle(sup_np), 0);
> +	fwnode_link_add(of_fwnode_handle(con_np), of_fwnode_handle(sup_np),
> +			flags);

I would leave it one line despite being 83 characters long.

...

> -			of_link_to_phandle(con_dev_np, phandle);
> +			of_link_to_phandle(con_dev_np, phandle,
> +					   s->fwlink_flags);

I would leave this on one line, it's only 81 characters.

-- 
With Best Regards,
Andy Shevchenko