Re: [patch net-next] dpll: spec: use proper enum for pin capabilities attribute

From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net,
	edumazet@google.com, arkadiusz.kubalewski@intel.com,
	vadim.fedorenko@linux.dev
Subject: Re: [patch net-next] dpll: spec: use proper enum for pin capabilities attribute
Date: Wed, 6 Mar 2024 16:25:34 +0100	[thread overview]
Message-ID: <ZeiK7gDRUZYA8378@nanopsycho> (raw)
In-Reply-To: <20240306120739.1447621-1-jiri@resnulli.us>

Wed, Mar 06, 2024 at 01:07:39PM CET, jiri@resnulli.us wrote:
>From: Jiri Pirko <jiri@nvidia.com>
>
>The enum is defined, however the pin capabilities attribute does
>refer to it. Add this missing enum field.
>
>This fixes ynl cli output:
>
>Example current output:
>$ sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0}'
>{'capabilities': 4,
> ...
>Example new output:
>$ sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0}'
>{'capabilities': {'state-can-change'},
> ...
>
>Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
>Signed-off-by: Jiri Pirko <jiri@nvidia.com>

Note that netdev/cc_maintainers fails as I didn't cc michal.michalik@intel.com
on purpose, as the address bounces.

Btw, do we have a way to ignore such ccs? .get_maintainer.ignore looks
like a good candidate, but is it okay to put closed emails there?