From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
Chandan Babu R <chandanbabu@kernel.org>
Subject: Re: [PATCH] Revert "blk-lib: check for kill signal"
Date: Wed, 13 Mar 2024 20:17:33 -0600 [thread overview]
Message-ID: <ZfJePaJi8ZhYYCh0@kbusch-mbp> (raw)
In-Reply-To: <20240314021623.1908895-1-hch@lst.de>
On Wed, Mar 13, 2024 at 07:16:23PM -0700, Christoph Hellwig wrote:
> This reverts commit 8a08c5fd89b447a7de7eb293a7a274c46b932ba2.
>
> It turns out while this is a perfectly valid and long overdue thing to do
> for user initiated discards / zeroing from the ioctl handler, it actually
> breaks file system use of the discard helper by interrupting in places
> the file system doesn't expect, and by leaving the bio chain in a state
> that the file system callers of (at least) __blkdev_issue_discard do
> not expect.
>
> Revert the change for now, we'll redo it for the next merge window
> after refactoring the code to better split the file system vs ioctl
> callers and cleaning up a few other loose ends.
>
> Reported-by: Chandan Babu R <chandanbabu@kernel.org>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Keith Busch <kbusch@kernel.org>
next prev parent reply other threads:[~2024-03-14 2:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 2:16 [PATCH] Revert "blk-lib: check for kill signal" Christoph Hellwig
2024-03-14 2:17 ` Keith Busch [this message]
2024-03-14 2:36 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfJePaJi8ZhYYCh0@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=chandanbabu@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.