Re: [PATCH v2 1/1] x86: Rename __{start,end}_init_task to __{start,end}_init_stack

From: Ingo Molnar <mingo@kernel.org>
To: "Xin Li (Intel)" <xin@zytor.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-arch@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
	hpa@zytor.com, jgross@suse.com, boris.ostrovsky@oracle.com,
	arnd@arndb.de, Brian Gerst <brgerst@gmail.com>
Subject: Re: [PATCH v2 1/1] x86: Rename __{start,end}_init_task to __{start,end}_init_stack
Date: Thu, 21 Mar 2024 20:54:37 +0100	[thread overview]
Message-ID: <ZfyQfQrluph6GxLS@gmail.com> (raw)
In-Reply-To: <20240318071429.910454-1-xin@zytor.com>

* Xin Li (Intel) <xin@zytor.com> wrote:

> The stack of a task has been separated from the memory of a task_struct
> struture for a long time on x86, as a result __{start,end}_init_task no
> longer mark the start and end of the init_task structure, but its stack
> only.
> 
> Rename __{start,end}_init_task to __{start,end}_init_stack.
> 
> Note other architectures are not affected because __{start,end}_init_task
> are used on x86 only.
> 
> Signed-off-by: Xin Li (Intel) <xin@zytor.com>
> ---
> 
> Change since v1:
> * Revert an accident insane change, init_task to init_stack (Jürgen Groß).
> ---
>  arch/x86/include/asm/processor.h  | 4 ++--
>  arch/x86/kernel/head_64.S         | 2 +-
>  arch/x86/xen/xen-head.S           | 2 +-
>  include/asm-generic/vmlinux.lds.h | 6 +++---
>  4 files changed, 7 insertions(+), 7 deletions(-)

Note that this is now in conflict with this cleanup by Brian Gerst:

   2cb16181a1d1 x86/boot: Simplify boot stack setup

... which removed __end_init_task[] entirely.

Thanks,

	Ingo