Re: [PATCH 2/2] clk: qcom: add IPQ9574 interconnect clocks support

From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: <andersson@kernel.org>, <robh@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<mturquette@baylibre.com>, <sboyd@kernel.org>,
	<djakov@kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-clk@vger.kernel.org>, <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 2/2] clk: qcom: add IPQ9574 interconnect clocks support
Date: Mon, 25 Mar 2024 15:52:08 +0530	[thread overview]
Message-ID: <ZgFQUMcLvYC16aec@hu-varada-blr.qualcomm.com> (raw)
In-Reply-To: <4b37a6e5-f917-4ead-9678-554a0d8f4660@linaro.org>

On Sat, Mar 23, 2024 at 01:29:00AM +0100, Konrad Dybcio wrote:
> On 21.03.2024 05:31, Varadarajan Narayanan wrote:
> > Unlike MSM platforms that manage NoC related clocks and scaling
> > from RPM, IPQ SoCs dont involve RPM in managing NoC related
> > clocks and there is no NoC scaling.
> >
> > However, there is a requirement to enable some NoC interface
> > clocks for accessing the peripheral controllers present on
> > these NoCs.
> >
> > Hence adding a minimalistic interconnect driver that can enable
> > the relevant clocks. This is similar to msm8996-cbf's usage of
> > icc-clk framework.
> >
> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > ---
>
> [...]
>
> > @@ -9,9 +9,16 @@
> >  #include <linux/of.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/regmap.h>
> > +#if IS_ENABLED(CONFIG_INTERCONNECT)
>
> This is bad practice, especially given the reasoning for your changes.
>
> It's best if you add a dependency on interconnect to this driver,
> otherwise things will go into uncountable EPROBE_DEFERs if there are
> nodes consuming icc handles, but the supplier never registers.
>
> [...]
>
> >
> >  static int gcc_ipq9574_probe(struct platform_device *pdev)
>
> ..and that approach could save the probe func from the absolute mess it
> has become with this patch
>
> Konrad

Thanks for the feedback. Have addressed these and other
reviewers comments and posted v2. Please take a look.

-Varada