Re: [PATCH 11/11] kpartx.rules: ignore DM_SUSPENDED

From: Benjamin Marzinski <bmarzins@redhat.com>
To: Martin Wilck <martin.wilck@suse.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>,
	dm-devel@lists.linux.dev, Peter Rajnoha <prajnoha@redhat.com>,
	Martin Wilck <mwilck@suse.com>
Subject: Re: [PATCH 11/11] kpartx.rules: ignore DM_SUSPENDED
Date: Tue, 26 Mar 2024 20:07:30 -0400	[thread overview]
Message-ID: <ZgNjQvNXikt-cW5h@bmarzins-01.fast.eng.rdu2.dc.redhat.com> (raw)
In-Reply-To: <20240324211301.7200-12-mwilck@suse.com>

On Sun, Mar 24, 2024 at 10:13:01PM +0100, Martin Wilck wrote:
> DM_SUSPENDED=1 implies DM_UDEV_DISABLE_OTHER_RULES_FLAG=1, no
> need to check it again. The DM_NOSCAN check needs to remain in
> order to keep compatibility with dm rules v2.
> 
> Signed-off-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
>  kpartx/kpartx.rules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kpartx/kpartx.rules b/kpartx/kpartx.rules
> index 1969dee..8dd3369 100644
> --- a/kpartx/kpartx.rules
> +++ b/kpartx/kpartx.rules
> @@ -27,7 +27,7 @@ ENV{DM_SUBSYSTEM_UDEV_FLAG1}=="1", GOTO="mpath_kpartx_end"
>  ENV{MPATH_UNCHANGED}=="1", GOTO="mpath_kpartx_end"
>  
>  # Don't run kpartx now if we know it will fail or hang.
> -ENV{DM_SUSPENDED}=="1", GOTO="mpath_kpartx_end"
> +# This is required for device mapper rules v2 compatibility.
>  ENV{DM_NOSCAN}=="1", GOTO="mpath_kpartx_end"
>  
>  # Run kpartx
> -- 
> 2.43.2