Re: [PATCH v2] hwrng: mxc-rnga: Drop usage of platform_driver_probe()

From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Olivia Mackall <olivia@selenic.com>,
	linux-crypto@vger.kernel.org, kernel@pengutronix.de,
	linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v2] hwrng: mxc-rnga: Drop usage of platform_driver_probe()
Date: Thu, 28 Mar 2024 18:58:04 +0800	[thread overview]
Message-ID: <ZgVNPH0EuGAjz/9R@gondor.apana.org.au> (raw)
In-Reply-To: <20240324161227.239718-2-u.kleine-koenig@pengutronix.de>

On Sun, Mar 24, 2024 at 05:12:26PM +0100, Uwe Kleine-König wrote:
> There are considerations to drop platform_driver_probe() as a concept
> that isn't relevant any more today. It comes with an added complexity
> that makes many users hold it wrong. (E.g. this driver should have mark
> the driver struct with __refdata.)
> 
> Convert the driver to the more usual module_platform_driver().
> 
> This fixes a W=1 build warning:
> 
> 	WARNING: modpost: drivers/char/hw_random/mxc-rnga: section mismatch in reference: mxc_rnga_driver+0x10 (section: .data) -> mxc_rnga_remove (section: .exit.text)
> 
> with CONFIG_HW_RANDOM_MXC_RNGA=m.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> while I indeed fixed the mentioned warning in (implicit) v1, I
> introduced another one because I failed to drop __init from
> mxc_rnga_probe. :-\
> 
> This is fixed here.
> 
> Best regards
> Uwe
> 
>  drivers/char/hw_random/mxc-rnga.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt