Re: [PATCH net-next v1 2/2] tools/net/ynl: Add multi message support to ynl

From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Donald Hunter <donald.hunter@gmail.com>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Stanislav Fomichev <sdf@google.com>,
	donald.hunter@redhat.com, fw@strlen.de,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH net-next v1 2/2] tools/net/ynl: Add multi message support to ynl
Date: Fri, 29 Mar 2024 23:12:04 +0100	[thread overview]
Message-ID: <Zgc8tPPX2fdJ1AJP@calendula> (raw)
In-Reply-To: <20240329144639.0b42dc19@kernel.org>

On Fri, Mar 29, 2024 at 02:46:39PM -0700, Jakub Kicinski wrote:
> On Fri, 29 Mar 2024 21:01:09 +0000 Donald Hunter wrote:
> > There's no response for 'batch-begin' or 'batch-end'. We may need a
> > per op spec property to tell us if a request will be acknowledged.
> 
> :(
> 
> Pablo, could we possibly start processing the ACK flags on those
> messages? Maybe the existing user space doesn't set ACK so nobody
> would notice?
> 
> I don't think the messages are otherwise marked as special from 
> the "netlink layer" perspective.

It is possible to explore this. I don't have a use-case for NLM_F_ACK
and the begin marker message at this stage.

Thanks.