From: Jan Beulich <jbeulich@suse.com>
To: pdurrant@amzn.com
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Paul Durrant" <pdurrant@amazon.com>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
xen-devel@lists.xenproject.org,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v3 1/6] domain: introduce alloc/free_shared_info() helpers...
Date: Fri, 6 Mar 2020 12:41:49 +0100 [thread overview]
Message-ID: <a03ffabd-14e7-703c-ad0a-ef716030fd1a@suse.com> (raw)
In-Reply-To: <20200305124504.3564-2-pdurrant@amzn.com>
On 05.03.2020 13:44, pdurrant@amzn.com wrote:
> From: Paul Durrant <pdurrant@amazon.com>
>
> ... and save the MFN.
>
> This patch modifies the 'shared_info' field of struct domain to be
> a structure comprising an MFN and a virtual address. Allocations are
> still done from xenheap, so the virtual address still equates to
> virt_to_mfn() called on the MFN but subsequent patch will change this.
> Hence the need to save the MFN.
>
> NOTE: Whist defining the new helpers, virt_to_mfn() in common/domain.c
> is made type safe.
> The definition of nmi_reason() in asm-x86/shared.h is also re-
> flowed to avoid overly long lines.
>
> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
> Reviewed-by: Julien Grall <julien@xen.org>
This patch by itself looks okay, but of course increases storage
requirements a little. Therefore
Acked-by: Jan Beulich <jbeulich@suse.com>
only if we reach agreement that the final patch in this series is
also to go in, which I'm yet to be convinced of.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-03-06 11:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 12:44 [Xen-devel] [PATCH v3 0/6] remove one more shared xenheap page: shared_info pdurrant
2020-03-05 12:44 ` [Xen-devel] [PATCH v3 1/6] domain: introduce alloc/free_shared_info() helpers pdurrant
2020-03-05 13:23 ` Xia, Hongyan
2020-03-05 13:25 ` Xia, Hongyan
2020-03-06 11:41 ` Jan Beulich [this message]
2020-03-05 12:45 ` [Xen-devel] [PATCH v3 2/6] x86 / p2m: remove page_list check in p2m_alloc_table pdurrant
2020-03-06 11:45 ` Jan Beulich
2020-03-06 12:07 ` Durrant, Paul
2020-03-06 12:46 ` Jan Beulich
2020-03-06 12:50 ` Durrant, Paul
2020-03-06 13:06 ` Jan Beulich
2020-03-06 13:11 ` [Xen-devel] [EXTERNAL][PATCH " Paul Durrant
2020-03-06 13:19 ` Jan Beulich
2020-03-06 13:25 ` Paul Durrant
2020-03-05 12:45 ` [Xen-devel] [PATCH v3 3/6] x86 / pv: do not treat PGC_extra pages as RAM when constructing dom0 pdurrant
2020-03-06 11:56 ` Jan Beulich
2020-03-06 12:03 ` Durrant, Paul
2020-03-06 13:39 ` Jan Beulich
2020-03-06 13:45 ` Paul Durrant
2020-03-06 13:47 ` Jan Beulich
2020-03-05 12:45 ` [Xen-devel] [PATCH v3 4/6] x86 / ioreq: use a MEMF_no_refcount allocation for server pages pdurrant
2020-03-06 12:03 ` Jan Beulich
2020-03-05 12:45 ` [Xen-devel] [PATCH v3 5/6] mm: add 'is_special_page' macro pdurrant
2020-03-05 15:09 ` Tamas K Lengyel
2020-03-05 15:38 ` Durrant, Paul
2020-03-05 15:58 ` Tamas K Lengyel
2020-03-06 7:02 ` Alan Robinson
2020-03-06 9:22 ` Durrant, Paul
2020-03-06 12:20 ` Jan Beulich
2020-03-06 12:35 ` Paul Durrant
2020-03-06 13:44 ` Jan Beulich
2020-03-06 13:48 ` Paul Durrant
2020-03-06 13:52 ` Jan Beulich
2020-03-06 13:57 ` Paul Durrant
2020-03-06 14:26 ` Julien Grall
2020-03-06 14:50 ` Jan Beulich
2020-03-05 12:45 ` [Xen-devel] [PATCH v3 6/6] domain: use PGC_extra domheap page for shared_info pdurrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a03ffabd-14e7-703c-ad0a-ef716030fd1a@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=pdurrant@amazon.com \
--cc=pdurrant@amzn.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.