From: Po-Wen Kao <powen.kao@mediatek.com>
To: Avri Altman <Avri.Altman@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>
Cc: "peter.wang@mediatek.com" <peter.wang@mediatek.com>,
"chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
"alice.chao@mediatek.com" <alice.chao@mediatek.com>,
"jonathan.hsu@mediatek.com" <jonathan.hsu@mediatek.com>,
"cc.chou@mediatek.com" <cc.chou@mediatek.com>,
"chaotian.jing@mediatek.com" <chaotian.jing@mediatek.com>,
"jiajie.hao@mediatek.com" <jiajie.hao@mediatek.com>,
"wsd_upstream@mediatek.com" <wsd_upstream@mediatek.com>,
"ed.tsai@mediatek.com" <ed.tsai@mediatek.com>
Subject: Re: [PATCH 0/2] Fix UFS task management command timeout
Date: Thu, 30 Sep 2021 16:50:38 +0800 [thread overview]
Message-ID: <a0c747584bf4190d1456f285d83670e807f31553.camel@mediatek.com> (raw)
In-Reply-To: <DM6PR04MB657502D8172084475F280CF5FCA99@DM6PR04MB6575.namprd04.prod.outlook.com>
Hi Avri,
Thanks for reminding. It's exactly the same issue.
Best,
Po-Wen Kao
On Wed, 2021-09-29 at 07:39 +0000, Avri Altman wrote:
> > On UTP_TASK_REQ_COMPL interrupt, ufshcd_tmc_handler() iterates
> > through
> > busy requests in tags->rqs and complete request if corresponding
> > doorbell flag is reset.
> > However, ufshcd_issue_tm_cmd() allocates requests from tags-
> > >static_rqs
> > and trigger doorbell directly without dispatching request through
> > block
> > layer, thus requests can never be found in tags->rqs and completed
> > properly. Any TM command issued by ufshcd_issue_tm_cmd() inevitably
> > timeout and further leads to recovery flow failure when LU Reset or
> > Abort Task is issued.
> >
> > In this patch, blk_mq_tagset_busy_iter() call in
> > ufshcd_tmc_handler()
> > is replaced with new interface, blk_mq_drv_tagset_busy_iter(), to
> > allow completion of request allocted by driver. The new interface
> > is
> > introduced for driver to iterate through requests in static_rqs.
>
> Is this the same issue that was addressed here -
> https://urldefense.com/v3/__https://www.spinics.net/lists/linux-scsi/msg164520.html__;!!CTRNKA9wMg0ARbw!yDkg-AVkMBFsnDBV42HMDgnE51HaEBarK2Tw8z8Di4aC1_7BrRkjIO13nz5rFUk-FA$
> A$ ?
>
> Thanks,
> Avri
>
> >
> > Po-Wen Kao (2):
> > blk-mq: new busy request iterator for driver
> > scsi: ufs: fix TM request timeout
> >
> > block/blk-mq-tag.c | 36 ++++++++++++++++++++++++++++++-----
> > -
> > drivers/scsi/ufs/ufshcd.c | 2 +-
> > include/linux/blk-mq.h | 4 ++++
> > 3 files changed, 35 insertions(+), 7 deletions(-)
> >
> > --
> > 2.18.0
>
>
prev parent reply other threads:[~2021-09-30 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 7:00 [PATCH 0/2] Fix UFS task management command timeout Po-Wen Kao
2021-09-29 7:00 ` [PATCH 1/2] blk-mq: new busy request iterator for driver Po-Wen Kao
2021-09-29 7:08 ` Christoph Hellwig
2021-09-29 7:00 ` [PATCH 2/2] scsi: ufs: fix TM request timeout Po-Wen Kao
2021-09-29 7:39 ` [PATCH 0/2] Fix UFS task management command timeout Avri Altman
2021-09-30 8:50 ` Po-Wen Kao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0c747584bf4190d1456f285d83670e807f31553.camel@mediatek.com \
--to=powen.kao@mediatek.com \
--cc=Avri.Altman@wdc.com \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=axboe@kernel.dk \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=ed.tsai@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=jonathan.hsu@mediatek.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.