From: Max Reitz <mreitz@redhat.com>
To: "Denis V. Lunev" <den@virtuozzo.com>, qemu-devel@nongnu.org
Cc: Anton Nefedov <anton.nefedov@virtuozzo.com>,
Jeff Cody <jcody@redhat.com>, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] mirror: do not increase offset during initial zero_or_discard phase - pls consider this as V3 patch
Date: Mon, 13 Feb 2017 18:16:36 +0100 [thread overview]
Message-ID: <a1049fab-1880-3b03-63bb-6b898ee55b40@redhat.com> (raw)
In-Reply-To: <169f96e8-0ca5-264d-350a-7f085905bd5b@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]
On 13.02.2017 08:10, Denis V. Lunev wrote:
> On 02/03/2017 06:08 PM, Denis V. Lunev wrote:
>> On 02/03/2017 06:06 PM, Denis V. Lunev wrote:
>>> From: Anton Nefedov <anton.nefedov@virtuozzo.com>
>>>
>>> If explicit zeroing out before mirroring is required for the target image,
>>> it moves the block job offset counter to EOF, then offset and len counters
>>> count the image size twice. There is no harm but stats are confusing,
>>> specifically the progress of the operation is always reported as 99% by
>>> management tools.
>>>
>>> The patch skips offset increase for the first "technical" pass over the
>>> image. This should not cause any further harm.
>>>
>>> Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
>>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>>> CC: Jeff Cody <jcody@redhat.com>
>>> CC: Kevin Wolf <kwolf@redhat.com>
>>> CC: Max Reitz <mreitz@redhat.com>
>> actually this is V3 patch. Sorry for broken subject.
>>
>> Den
> ping
Didn't Jeff merge v2?
http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg01319.html
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2017-02-13 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 15:06 [Qemu-devel] [PATCH 1/1] mirror: do not increase offset during initial zero_or_discard phase Denis V. Lunev
2017-02-03 15:08 ` [Qemu-devel] [PATCH 1/1] mirror: do not increase offset during initial zero_or_discard phase - pls consider this as V3 patch Denis V. Lunev
2017-02-13 7:10 ` Denis V. Lunev
2017-02-13 17:16 ` Max Reitz [this message]
2017-02-13 19:13 ` Jeff Cody
2017-02-13 19:45 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1049fab-1880-3b03-63bb-6b898ee55b40@redhat.com \
--to=mreitz@redhat.com \
--cc=anton.nefedov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.