From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Raymond Hackley <raymondhackley@protonmail.com>,
linux-kernel@vger.kernel.org
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>,
Nikita Travkin <nikita@trvn.ru>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 1/2] arm64: dts: qcom: msm8916/8216-samsung-fortuna: Add samsung,fortuna binding
Date: Sat, 30 Mar 2024 19:42:03 +0100 [thread overview]
Message-ID: <a11c2adf-d72f-4385-a59e-ce640b8bb7d3@linaro.org> (raw)
In-Reply-To: <20240326141222.200452-2-raymondhackley@protonmail.com>
On 26/03/2024 15:12, Raymond Hackley wrote:
> Add common binding samsung,fortuna used by the following
> Samsung Galaxy Grand Prime devices:
> - SM-G530FZ (msm8916-samsung-grandprimelte)
> - SM-G530H (msm8216-samsung-fortuna3g)
> - SM-G530W (msm8916-gprimeltecan)
>
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---
> arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts | 2 +-
> arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts | 2 +-
> arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts b/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts
> index 366914be7d53..877fd2d7bb57 100644
> --- a/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts
> @@ -6,6 +6,6 @@
>
> / {
> model = "Samsung Galaxy Grand Prime (SM-G530H)";
> - compatible = "samsung,fortuna3g", "qcom,msm8916";
> + compatible = "samsung,fortuna3g", "samsung,fortuna", "qcom,msm8916";
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-30 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 14:12 [PATCH 0/2] arm64: dts: qcom: msm8916/8216-samsung-fortuna: Add samsung,fortuna binding Raymond Hackley
2024-03-26 14:12 ` [PATCH 1/2] " Raymond Hackley
2024-03-30 18:42 ` Krzysztof Kozlowski [this message]
2024-03-26 14:12 ` [PATCH 2/2] dt-bindings: qcom: Document samsung,fortuna Raymond Hackley
2024-03-27 15:43 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a11c2adf-d72f-4385-a59e-ce640b8bb7d3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=raymondhackley@protonmail.com \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.