From: Julien Grall <julien@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops
Date: Tue, 3 Jan 2023 20:47:43 +0000 [thread overview]
Message-ID: <a1300a9e-26a2-4307-d1c3-102729f16a09@xen.org> (raw)
In-Reply-To: <20230103200943.5801-5-andrew.cooper3@citrix.com>
Hi Andrew,
On 03/01/2023 20:09, Andrew Cooper wrote:
> diff --git a/xen/include/public/version.h b/xen/include/public/version.h
> index c8325219f648..cf2d2ef38b54 100644
> --- a/xen/include/public/version.h
> +++ b/xen/include/public/version.h
> @@ -19,12 +19,20 @@
> /* arg == NULL; returns major:minor (16:16). */
> #define XENVER_version 0
>
> -/* arg == xen_extraversion_t. */
> +/*
> + * arg == xen_extraversion_t.
> + *
> + * This API/ABI is broken. Use XENVER_extraversion2 instead.
I read this as newer tools should never try to call XENVER_extraversion.
But I don't think this is what you intend to say, correct? If so, I
would say that an OS should first try XENVER_extraversion2 and then
fallback to XENVER_extraversion if it returns -ENOSYS.
Same goes for the new hypercalls.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2023-01-03 20:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 20:09 [PATCH 0/4] Fix truncation of various XENVER_* subops Andrew Cooper
2023-01-03 20:09 ` [PATCH 1/4] public/version: Change xen_feature_info to have a fixed size Andrew Cooper
2023-01-04 9:03 ` Julien Grall
2023-01-03 20:09 ` [PATCH 2/4] xen/version: Drop compat/kernel.c Andrew Cooper
2023-01-04 16:29 ` Jan Beulich
2023-01-04 19:15 ` Andrew Cooper
2023-01-05 7:22 ` Jan Beulich
2023-01-04 16:48 ` Jan Beulich
2023-01-03 20:09 ` [PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters Andrew Cooper
2023-01-04 16:40 ` Jan Beulich
2023-01-04 19:55 ` Andrew Cooper
2023-01-05 7:57 ` Jan Beulich
2023-01-05 22:17 ` Andrew Cooper
2023-01-06 7:54 ` Jan Beulich
2023-01-06 12:14 ` Andrew Cooper
2023-01-09 8:06 ` Jan Beulich
2023-01-03 20:09 ` [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops Andrew Cooper
2023-01-03 20:47 ` Julien Grall [this message]
2023-01-03 21:22 ` Andrew Cooper
2023-01-03 21:40 ` Julien Grall
2023-01-04 17:04 ` Jan Beulich
2023-01-04 18:34 ` Andrew Cooper
2023-01-05 8:15 ` Jan Beulich
2023-01-05 22:28 ` Andrew Cooper
2023-01-06 7:56 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1300a9e-26a2-4307-d1c3-102729f16a09@xen.org \
--to=julien@xen.org \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.