From: Sibi Sankar <sibis@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: robh+dt@kernel.org, andy.gross@linaro.org,
david.brown@linaro.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, tsoni@codeaurora.org,
clew@codeaurora.org, akdwived@codeaurora.org, ohad@wizery.com,
mark.rutland@arm.com, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: remoteproc: qcom: Add power-domain bindings for Q6V5
Date: Thu, 06 Dec 2018 23:14:37 +0530 [thread overview]
Message-ID: <a162ed66f2017b42c3d30e9279e363a3@codeaurora.org> (raw)
In-Reply-To: <20181206165810.GC31596@builder>
Hi Bjorn,
Thanks for the review!
On 2018-12-06 22:28, Bjorn Andersson wrote:
> On Tue 20 Nov 13:08 PST 2018, Sibi Sankar wrote:
>
>> Add power-domain bindings for Q6V5 MSS on SDM845 SoCs.
>>
>
> Thanks Sibi,
>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>>
>> Add dt-binding corresponding to
>> https://patchwork.kernel.org/patch/10586893/
>> (remoteproc: q6v5: Add support to vote for rpmh power domains)
>>
>> .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 11
>> +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> index 14947562bc67..bd9f4882fcf0 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> @@ -75,6 +75,17 @@ on the Qualcomm Hexagon core.
>> Definition: reference to the regulators to be held on behalf of the
>> booting of the Hexagon core
>>
>> +- power-domains:
>> + Usage: required
>> + Value type: <phandle>
>> + Definition: reference to the cx, mx and mss power-domains to be held
>> on
>> + behalf of the booting the Hexagon core
>
> This should mention that these are the domains for SDM845, as the list
> seems to differ somewhat between platforms. Please also define the
> requirements for MSM8996 (cx & mx) here, while you're at it.
>
> Let's also make sure it includes the "load_state", for SDM845.
>
I'll list the power domains per SoC in the next respin
> Regards,
> Bjorn
>
>> +
>> +- power-domain-names:
>> + Usage: required
>> + Value type: <stringlist>
>> + Definition: must be "cx", "mx", "mss"
>> +
>> - qcom,smem-states:
>> Usage: required
>> Value type: <phandle>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-12-06 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 21:08 [PATCH] dt-bindings: remoteproc: qcom: Add power-domain bindings for Q6V5 Sibi Sankar
2018-12-05 22:55 ` Rob Herring
2018-12-05 22:55 ` Rob Herring
2018-12-05 22:55 ` Rob Herring
2018-12-06 16:58 ` Bjorn Andersson
2018-12-06 17:44 ` Sibi Sankar [this message]
2018-12-13 22:05 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a162ed66f2017b42c3d30e9279e363a3@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=akdwived@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.