Re: [PATCH v2 3/3] xen/heap: pass order to free_heap_pages() in heap init

From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: Hongyan Xia <hongyxia@amazon.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Julien Grall <jgrall@amazon.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 3/3] xen/heap: pass order to free_heap_pages() in heap init
Date: Wed, 20 Jul 2022 19:27:07 +0100	[thread overview]
Message-ID: <a1c001b6-3a4a-a118-c343-f2c47a6e3d11@xen.org> (raw)
In-Reply-To: <4904ae1b-19ef-533c-fc2f-baec570bfcca@suse.com>

Hi Jan,

On 19/07/2022 07:01, Jan Beulich wrote:
> On 18.07.2022 19:39, Julien Grall wrote:
>> On 18/07/2022 12:02, Jan Beulich wrote:
>>> On 18.07.2022 12:24, Julien Grall wrote:
>>> 3)
>>>           unsigned int inc_order = min(MAX_ORDER, flsl(e - s) - 1);
>>>
>>>           if ( s )
>>>               inc_order = min(inc_order, ffsl(s) - 1U);
>>
>> I like this idea!
>>
>>>
>>> No compilation issues to expect here, afaict.
>>
>> Correct, GCC is happy with this approach. Assuming there are no other
>> comments, are you happy if I make the change on commit?
> 
> Sure - iirc I gave my R-b already.

You did. Just wanted to make sure your reviewed-by was valid with your 
proposal.

I have now committed the series.

Cheers,

-- 
Julien Grall