From: fdmanana@kernel.org
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 6/6] btrfs: remove stale comment about locking at btrfs_search_slot()
Date: Thu, 2 Dec 2021 10:30:40 +0000 [thread overview]
Message-ID: <a2a4e75a7ec612acb6223b408e4722d62dd0cd22.1638440535.git.fdmanana@suse.com> (raw)
In-Reply-To: <cover.1638440535.git.fdmanana@suse.com>
From: Filipe Manana <fdmanana@suse.com>
The comment refers to the old extent buffer locking code, where we used to
have custom locks that had blocking and spinning behaviour modes. That is
not the case anymore, since we have transitioned to rw semaphores, so the
comment does not offer any value anymore. Remove it.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
fs/btrfs/ctree.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index bcf99c787d68..fdd286ab1259 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -1963,10 +1963,6 @@ int btrfs_search_slot(struct btrfs_trans_handle *trans, struct btrfs_root *root,
}
cow_done:
p->nodes[level] = b;
- /*
- * Leave path with blocking locks to avoid massive
- * lock context switch, this is made on purpose.
- */
/*
* we have a lock on b and as long as we aren't changing
--
2.33.0
next prev parent reply other threads:[~2021-12-02 10:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 10:30 [PATCH 0/6] btrfs: optimize btree insertions and some cleanups fdmanana
2021-12-02 10:30 ` [PATCH 1/6] btrfs: allow generic_bin_search() to take low boundary as an argument fdmanana
2021-12-02 10:30 ` [PATCH 2/6] btrfs: try to unlock parent nodes earlier when inserting a key fdmanana
2021-12-02 10:30 ` [PATCH 3/6] btrfs: remove useless condition check before splitting leaf fdmanana
2021-12-02 10:30 ` [PATCH 4/6] btrfs: move leaf search logic out of btrfs_search_slot() fdmanana
2021-12-02 10:30 ` [PATCH 5/6] btrfs: remove BUG_ON() after splitting leaf fdmanana
2021-12-02 10:30 ` fdmanana [this message]
2021-12-02 19:45 ` [PATCH 0/6] btrfs: optimize btree insertions and some cleanups Josef Bacik
2021-12-06 18:29 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2a4e75a7ec612acb6223b408e4722d62dd0cd22.1638440535.git.fdmanana@suse.com \
--to=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.