From: Marek Vasut <marex@denx.de>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/4] clk: rs9: Support device specific dif bit calculation
Date: Tue, 10 Jan 2023 14:37:19 +0100 [thread overview]
Message-ID: <a2fd6077-a5ae-a694-3637-e83ca044da69@denx.de> (raw)
In-Reply-To: <3216146.44csPzL39Z@steina-w>
On 1/10/23 14:22, Alexander Stein wrote:
> Hi Marek,
Hi,
> thanks for your feedback.
>
> Am Dienstag, 10. Januar 2023, 11:31:49 CET schrieb Marek Vasut:
>> On 1/10/23 11:00, Alexander Stein wrote:
>>
>> [...]
>>
>>> static int rs9_get_output_config(struct rs9_driver_data *rs9, int idx)
>>> {
>>>
>>> struct i2c_client *client = rs9->client;
>>>
>>> + u8 dif = rs9_calc_dif(rs9, idx);
>>>
>>> unsigned char name[5] = "DIF0";
>>> struct device_node *np;
>>> int ret;
>>> u32 sr;
>>>
>>> /* Set defaults */
>>>
>>> - rs9->clk_dif_sr &= ~RS9_REG_SR_DIF_MASK(idx);
>>
>> Are you sure this line ^ should be dropped ?
>> Shouldn't the bitfield be cleared first and modified second?
>
> Well, I had in my mind that this function is called upon probe with clk_dif_sr
> being cleared anyway, so this does essentially nothing. And the DIF bit is set
> unconditionally, so what is the point of masking it before?
Good point, but then, what's the point of ORRing either ? Just do a
plain assignment.
next prev parent reply other threads:[~2023-01-10 13:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 10:00 [PATCH v2 1/4] clk: rs9: Check for vendor/device ID Alexander Stein
2023-01-10 10:00 ` [PATCH v2 2/4] dt-bindings: clk: rs9: Add 9FGV0441 Alexander Stein
2023-01-10 10:29 ` Marek Vasut
2023-01-10 10:00 ` [PATCH v2 3/4] clk: rs9: Support device specific dif bit calculation Alexander Stein
2023-01-10 10:31 ` Marek Vasut
2023-01-10 13:22 ` Alexander Stein
2023-01-10 13:37 ` Marek Vasut [this message]
2023-01-10 13:47 ` Alexander Stein
2023-01-10 13:51 ` Marek Vasut
2023-01-10 10:00 ` [PATCH v2 4/4] clk: rs9: Add support for 9FGV0441 Alexander Stein
2023-01-10 10:32 ` Marek Vasut
2023-01-10 10:28 ` [PATCH v2 1/4] clk: rs9: Check for vendor/device ID Marek Vasut
2023-02-13 7:28 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2fd6077-a5ae-a694-3637-e83ca044da69@denx.de \
--to=marex@denx.de \
--cc=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.