Re: [PATCH 2/3] tools/libxc: change xc_memshr_fork_reset API to match hypervisor

From: Jan Beulich <jbeulich@suse.com>
To: Tamas K Lengyel <tamas.k.lengyel@gmail.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
	xen-devel@lists.xenproject.org, "Juergen Gross" <jgross@suse.com>,
	"Anthony PERARD" <anthony.perard@citrix.com>,
	"Wei Liu" <wl@xen.org>
Subject: Re: [PATCH 2/3] tools/libxc: change xc_memshr_fork_reset API to match hypervisor
Date: Thu, 19 May 2022 08:03:53 +0200	[thread overview]
Message-ID: <a3c4a082-9c4e-c288-7729-94cb5264e3b1@suse.com> (raw)
In-Reply-To: <CABfawhmSFxa23PrmCzaQEvqUE1nZuVB1i1iw_terDa1BCq5gig@mail.gmail.com>

On 18.05.2022 19:03, Tamas K Lengyel wrote:
> On Wed, May 18, 2022 at 11:48 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 18.05.2022 17:01, Tamas K Lengyel wrote:
>>> On Thu, May 12, 2022 at 9:46 AM Tamas K Lengyel
>>> <tamas.k.lengyel@gmail.com> wrote:
>>>>
>>>> On Thu, May 5, 2022 at 4:27 AM Roger Pau Monné <roger.pau@citrix.com> wrote:
>>>>>
>>>>> On Wed, Apr 27, 2022 at 11:34:19AM -0400, Tamas K Lengyel wrote:
>>>>>> Need to separately specify if the reset is for the memory or for the VM state,
>>>>>> or both.
>>>>>>
>>>>>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
>>>>>
>>>>> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
>>>>
>>>> Patch ping. Can this patch be merged please?
>>>
>>> Patch ping.
>>
>> Your mail (and I guess also your earlier one) was _To_ Roger, which
>> is odd since he already did provide R-b. What you're missing is a
>> tool stack maintainer ack aiui, so it may help if you send your
>> pings _To_ the respective people.
> 
> True, but all the toolstack maintainers have been CC-d from the start.
> Is it the case that CC-ing is now officially insufficient?

No - patch submissions should still only Cc maintainers. But I think
pings, especially repeated ones, would better go To the respective
people. (And this follows my general remark I keep making every once
in a while: There's a reason there is both To and Cc, and using them
appropriately can help. Of course there's no guarantee, as people
may not pay attention at all.)

> What's the
> point of ./scripts/add_maintainers.pl then which specifically adds
> maintainers only as CC? How are you supposed to get their attention?
> Just know you specifically have to send emails to them and not the
> mailinglist? I'm getting the distinct impression that the toolstack
> side has simply become unmaintained/orphaned with no one left who
> actually is looking at the mailinglist.

While things are far from ideal (and as you likely know we're still
looking for a 2nd tool stack maintainer), I have actually got the
impression that things have improved a little lately.

Jan