From: Chanwoo Choi <cw00.choi@samsung.com>
To: "Artur Świgoń" <a.swigon@samsung.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Cc: georgi.djakov@linaro.org, b.zolnierkie@samsung.com,
m.szyprowski@samsung.com, krzk@kernel.org
Subject: Re: [PATCH v4 2/3] interconnect: Relax requirement in of_icc_get_from_provider()
Date: Fri, 17 Jan 2020 14:24:00 +0900 [thread overview]
Message-ID: <a4068452-0de0-dc5d-a7a9-3312723a9163@samsung.com> (raw)
In-Reply-To: <20200116144202.12116-3-a.swigon@samsung.com>
Hi,
On 1/16/20 11:42 PM, Artur Świgoń wrote:
> This patch relaxes the condition in of_icc_get_from_provider() so that
> it is no longer required to set '#interconnect-cells' to <1> in the DT,
> and therefore it is not required to supply dummy node IDs in the
> 'interconnects' property when node IDs are dynamically generated rather
> than hardcoded (statically allocated).
>
> In case of the devfreq driver for exynos-bus, node IDs are dynamically
> allocated and '#interconnect-cells' is always zero.
>
> Signed-off-by: Artur Świgoń <a.swigon@samsung.com>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/interconnect/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index 0be1764d3528..5ea270af5ff4 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -335,7 +335,7 @@ struct icc_node *of_icc_get_from_provider(struct of_phandle_args *spec)
> struct icc_node *node = ERR_PTR(-EPROBE_DEFER);
> struct icc_provider *provider;
>
> - if (!spec || spec->args_count != 1)
> + if (!spec)
> return ERR_PTR(-EINVAL);
>
> mutex_lock(&icc_lock);
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2020-01-17 5:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200116144241eucas1p226c1d7fc2fad5bd1b9fb6d0fb1b22bff@eucas1p2.samsung.com>
2020-01-16 14:41 ` [PATCH v4 0/3] interconnect: Support Samsung Exynos use-case Artur Świgoń
[not found] ` <CGME20200116144241eucas1p18dcf099873015e955d71d90712bbe9e0@eucas1p1.samsung.com>
2020-01-16 14:42 ` [PATCH v4 1/3] interconnect: Export of_icc_get_from_provider() Artur Świgoń
2020-01-23 9:21 ` Georgi Djakov
2020-01-24 11:22 ` Artur Świgoń
[not found] ` <CGME20200116144242eucas1p2bf8b4df91355974c8c96778f4ec117f7@eucas1p2.samsung.com>
2020-01-16 14:42 ` [PATCH v4 2/3] interconnect: Relax requirement in of_icc_get_from_provider() Artur Świgoń
2020-01-17 5:24 ` Chanwoo Choi [this message]
[not found] ` <CGME20200116144242eucas1p1b66d8ca0d111f140c48b80c5064ca4ff@eucas1p1.samsung.com>
2020-01-16 14:42 ` [PATCH v4 3/3] interconnect: Allow inter-provider pairs to be configured Artur Świgoń
2020-01-17 5:31 ` [PATCH v4 0/3] interconnect: Support Samsung Exynos use-case Chanwoo Choi
2020-01-17 6:10 ` Artur Świgoń
2020-01-17 7:14 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4068452-0de0-dc5d-a7a9-3312723a9163@samsung.com \
--to=cw00.choi@samsung.com \
--cc=a.swigon@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=georgi.djakov@linaro.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.