From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jason Wang <jasowang@redhat.com>, stefanha@redhat.com, mst@redhat.com
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] vhost-vsock: fix use after free
Date: Thu, 27 Sep 2018 12:52:50 +0300 [thread overview]
Message-ID: <a413a8b4-302d-7fbc-092d-95e8aa421c4c@cogentembedded.com> (raw)
In-Reply-To: <20180927084301.573-1-jasowang@redhat.com>
Hello!
On 9/27/2018 11:43 AM, Jason Wang wrote:
Just a couple of typos...
> The access of vsock is not protected by vhost_vsock_lock. This may
> lead use after free since vhost_vsock_dev_release() may free the
Lead to use.
> pointer at the same time.
>
> Fix this by holding the lock during the acess.
Access.
> Reported-by: syzbot+e3e074963495f92a89ed@syzkaller.appspotmail.com
> Fixes: 16320f363ae1 ("vhost-vsock: add pkt cancel capability")
> Fixes: 433fc58e6bf2 ("VSOCK: Introduce vhost_vsock.ko")
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2018-09-27 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 8:43 [PATCH net] vhost-vsock: fix use after free Jason Wang
2018-09-27 9:52 ` Sergei Shtylyov [this message]
2018-09-27 12:21 ` Jason Wang
2018-09-27 12:21 ` Jason Wang
2018-09-27 9:52 ` Sergei Shtylyov
2018-09-27 8:43 Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a413a8b4-302d-7fbc-092d-95e8aa421c4c@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.