From: Mark Brown <broonie@kernel.org>
To: Peter Enderborg <peter.enderborg@sony.com>
Cc: Yingsha Xu <ysxu@hust.edu.cn>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Serge Semin <fancer.lancer@gmail.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: remove return value check of debugfs_create_dir()
Date: Mon, 24 Apr 2023 13:32:14 +0100 [thread overview]
Message-ID: <a4706089-399b-4663-9ac8-216f12ebe7ca@sirena.org.uk> (raw)
In-Reply-To: <368e31ae-31b5-839f-72e3-20a27239cb0b@sony.com>
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
On Mon, Apr 24, 2023 at 02:20:45PM +0200, Peter Enderborg wrote:
> On 4/24/23 13:54, Mark Brown wrote:
> > This is very much a question of taste with a range of use cases
> > available.
> No.
> https://lkml.iu.edu/hypermail/linux/kernel/1901.2/05993.html
> We can do things with the debug information without filesystem enabled.
There's issues with partially created debugfs structures getting in the
way of people trying to debug things, just completely ignoring all
errors can create confusion as the diagnostic information people believe
is being shown to them ends up being partial or mistructured without any
indication that this has happened.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-04-24 12:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 6:11 [PATCH] spi: remove return value check of debugfs_create_dir() Yingsha Xu
2023-04-24 11:54 ` Mark Brown
2023-04-24 12:20 ` Peter Enderborg
2023-04-24 12:32 ` Mark Brown [this message]
2023-04-24 12:53 ` Greg Kroah-Hartman
2023-04-24 13:00 ` Mark Brown
2023-04-24 13:08 ` Greg Kroah-Hartman
2023-04-24 13:17 ` Mark Brown
2023-04-24 13:17 ` Peter Enderborg
2023-04-24 13:22 ` Greg Kroah-Hartman
2023-04-24 13:54 ` Peter Enderborg
2023-04-25 5:31 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4706089-399b-4663-9ac8-216f12ebe7ca@sirena.org.uk \
--to=broonie@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=peter.enderborg@sony.com \
--cc=ysxu@hust.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.