From: Hans de Goede <hdegoede@redhat.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
"Mark Gross" <mgross@linux.intel.com>,
"Mario Limonciello" <mario.limonciello@dell.com>,
platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: dell-wmi-descriptor: disable by default
Date: Tue, 16 Nov 2021 10:58:22 +0100 [thread overview]
Message-ID: <a4ac11cb-432e-fba1-81af-0bccd30ebb86@redhat.com> (raw)
In-Reply-To: <20211113080551.61860-1-linux@weissschuh.net>
Hi,
On 11/13/21 09:05, Thomas Weißschuh wrote:
> dell-wmi-descriptor only provides symbols to other drivers.
> These drivers already select dell-wmi-descriptor when needed.
>
> This fixes an issue where dell-wmi-descriptor is compiled as a module
> with localyesconfig on a non-Dell machine.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/dell/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig
> index 821aba31821c..dbc71a936339 100644
> --- a/drivers/platform/x86/dell/Kconfig
> +++ b/drivers/platform/x86/dell/Kconfig
> @@ -187,7 +187,7 @@ config DELL_WMI_AIO
>
> config DELL_WMI_DESCRIPTOR
> tristate
> - default m
> + default n
> depends on ACPI_WMI
>
> config DELL_WMI_LED
>
> base-commit: 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
>
prev parent reply other threads:[~2021-11-16 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 8:05 [PATCH] platform/x86: dell-wmi-descriptor: disable by default Thomas Weißschuh
2021-11-16 9:58 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4ac11cb-432e-fba1-81af-0bccd30ebb86@redhat.com \
--to=hdegoede@redhat.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mario.limonciello@dell.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.