Re: [PATCH net] net/smc: Remove redundant refcount increase

From: Wenjia Zhang <wenjia@linux.ibm.com>
To: liuyacan@corp.netease.com
Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	kgraul@linux.ibm.com, Jan Karcher <jaka@linux.ibm.com>
Subject: Re: [PATCH net] net/smc: Remove redundant refcount increase
Date: Thu, 1 Sep 2022 07:42:13 +0200	[thread overview]
Message-ID: <a4c368d3-d293-10e8-1089-5a2654735e15@linux.ibm.com> (raw)
In-Reply-To: <20220829145329.2751578-1-liuyacan@corp.netease.com>


On 29.08.22 16:53, liuyacan@corp.netease.com wrote:
> From: liuyacan <liuyacan@corp.netease.com>
> 
> For passive connections, the refcount increment has been done in
> smc_clcsock_accept()-->smc_sock_alloc().
> 
> Fixes: 3b2dec2603d5("net/smc: restructure client and server code in af_smc")
> Signed-off-by: liuyacan <liuyacan@corp.netease.com>
> ---
>   net/smc/af_smc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 79c1318af..0939cc3b9 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -1855,7 +1855,6 @@ static void smc_listen_out_connected(struct smc_sock *new_smc)
>   {
>   	struct sock *newsmcsk = &new_smc->sk;
>   
> -	sk_refcnt_debug_inc(newsmcsk);
>   	if (newsmcsk->sk_state == SMC_INIT)
>   		newsmcsk->sk_state = SMC_ACTIVE;
>   
Good catch! Thank you for the patch! But fixes should go to the net-next 
tree.