From: Hans de Goede <hdegoede@redhat.com>
To: Mark Gross <markgross@kernel.org>, Andy Shevchenko <andy@kernel.org>
Cc: platform-driver-x86@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] platform/x86: x86-android-tablets: Depend on EFI and SPI
Date: Tue, 8 Mar 2022 16:33:58 +0100 [thread overview]
Message-ID: <a54aab27-e469-5220-273f-f844ceea8155@redhat.com> (raw)
In-Reply-To: <20220308152942.262130-1-hdegoede@redhat.com>
Hi,
On 3/8/22 16:29, Hans de Goede wrote:
> The recently added support for Lenovo Yoga Tablet 2 tablets uses
> symbols from EFI and SPI add "depends on EFI && SPI" to the
> X86_ANDROID_TABLETS Kconfig entry.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
I've added this to my review-hans (soon to be for-next) branch now.
Regards,
Hans
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 0d51011d5d90..5d9dd70e4e0f 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1041,7 +1041,7 @@ config TOUCHSCREEN_DMI
>
> config X86_ANDROID_TABLETS
> tristate "X86 Android tablet support"
> - depends on I2C && SERIAL_DEV_BUS && ACPI && GPIOLIB
> + depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB
> help
> X86 tablets which ship with Android as (part of) the factory image
> typically have various problems with their DSDTs. The factory kernels
next prev parent reply other threads:[~2022-03-08 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 15:29 [PATCH] platform/x86: x86-android-tablets: Depend on EFI and SPI Hans de Goede
2022-03-08 15:33 ` Hans de Goede [this message]
2022-03-08 21:35 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a54aab27-e469-5220-273f-f844ceea8155@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.