From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Chris Mi <chrism@mellanox.com>, netdev@vger.kernel.org
Cc: xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
mawilcox@microsoft.com
Subject: Re: [patch net-next 2/3] net/sched: Change cls_flower to use IDR
Date: Mon, 28 Aug 2017 17:55:44 -0400 [thread overview]
Message-ID: <a562fbec-797f-1cb2-8af5-cce36126aa23@mojatatu.com> (raw)
In-Reply-To: <1503902477-39829-3-git-send-email-chrism@mellanox.com>
On 17-08-28 02:41 AM, Chris Mi wrote:
> Currently, all filters with the same priority are linked in a doubly
> linked list. Every filter should have a unique handle. To make the
> handle unique, we need to iterate the list every time to see if the
> handle exists or not when inserting a new filter. It is time-consuming.
> For example, it takes about 5m3.169s to insert 64K rules.
>
> This patch changes cls_flower to use IDR. With this patch, it
> takes about 0m1.127s to insert 64K rules. The improvement is huge.
>
> But please note that in this testing, all filters share the same action.
> If every filter has a unique action, that is another bottleneck.
> Follow-up patch in this patchset addresses that.
>
> Signed-off-by: Chris Mi <chrism@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
As Cong asked last time - any plans to add to other classifiers?
cheers,
jamal
next prev parent reply other threads:[~2017-08-28 21:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 6:41 [patch net-next 0/3] net/sched: Improve getting objects by indexes Chris Mi
2017-08-28 6:41 ` [patch net-next 1/3] idr: Add new APIs to support unsigned long Chris Mi
2017-08-29 7:14 ` Hannes Frederic Sowa
2017-08-29 7:34 ` Chris Mi
2017-08-29 7:57 ` Jiri Pirko
2017-08-29 8:00 ` Chris Mi
2017-08-29 7:56 ` Jiri Pirko
2017-08-28 6:41 ` [patch net-next 2/3] net/sched: Change cls_flower to use IDR Chris Mi
2017-08-28 11:37 ` Simon Horman
2017-08-29 3:25 ` Chris Mi
2017-08-30 10:30 ` Simon Horman
2017-08-28 21:55 ` Jamal Hadi Salim [this message]
2017-08-29 1:34 ` Chris Mi
2017-08-28 6:41 ` [patch net-next 3/3] net/sched: Change act_api and act_xxx modules " Chris Mi
2017-08-28 21:56 ` Jamal Hadi Salim
-- strict thread matches above, loose matches on Subject: below --
2017-08-16 2:12 [patch net-next 0/3] net/sched: Improve getting objects by indexes Chris Mi
2017-08-16 2:12 ` [patch net-next 2/3] net/sched: Change cls_flower to use IDR Chris Mi
2017-08-16 2:12 ` Chris Mi
2017-08-16 2:12 ` Chris Mi
2017-08-16 2:12 ` Chris Mi
2017-08-16 2:12 ` Chris Mi
2017-08-16 2:12 ` Chris Mi
2017-08-16 2:12 ` Chris Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a562fbec-797f-1cb2-8af5-cce36126aa23@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=chrism@mellanox.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=mawilcox@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.