From: Hans Verkuil <hverkuil@xs4all.nl>
To: Yang Li <yang.lee@linux.alibaba.com>, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] media: v4l2-ctrls: clean up some inconsistent indentings
Date: Fri, 27 Jan 2023 09:36:40 +0100 [thread overview]
Message-ID: <a66fec48-ae2e-034f-ecb2-4b0c3196d59c@xs4all.nl> (raw)
In-Reply-To: <20221216074212.45386-1-yang.lee@linux.alibaba.com>
On 16/12/2022 08:42, Yang Li wrote:
> clean up some inconsistent indentings to improve the readability of the
> code.
>
> drivers/media/v4l2-core/v4l2-ctrls-api.c:154 user_to_new() warn: inconsistent indenting
Thank you for the patch, but the actual fix is already on its way
to mainline:
https://patchwork.linuxtv.org/project/linux-media/patch/69624c54-7cbd-7362-c468-f8ffea9614be@xs4all.nl/
Rejecting this in patchwork.
Regards,
Hans
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3503
> Fixes: 73278d483378 ("media: v4l2-ctrls-api.c: add back dropped ctrl->is_new = 1")
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/media/v4l2-core/v4l2-ctrls-api.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ctrls-api.c b/drivers/media/v4l2-core/v4l2-ctrls-api.c
> index 3d3b6dc24ca6..3bee4ad5be7c 100644
> --- a/drivers/media/v4l2-core/v4l2-ctrls-api.c
> +++ b/drivers/media/v4l2-core/v4l2-ctrls-api.c
> @@ -150,8 +150,8 @@ static int user_to_new(struct v4l2_ext_control *c, struct v4l2_ctrl *ctrl)
> * then return an error.
> */
> if (strlen(ctrl->p_new.p_char) == ctrl->maximum && last)
> - ctrl->is_new = 1;
> - return -ERANGE;
> + ctrl->is_new = 1;
> + return -ERANGE;
> }
> return ret;
> default:
prev parent reply other threads:[~2023-01-27 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 7:42 [PATCH -next] media: v4l2-ctrls: clean up some inconsistent indentings Yang Li
2023-01-27 8:36 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a66fec48-ae2e-034f-ecb2-4b0c3196d59c@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=abaci@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.