From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Felipe Balbi <balbi@kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: John Youn <John.Youn@synopsys.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: gadget: Remove FS bInterval_m1 limitation
Date: Thu, 15 Apr 2021 07:10:36 +0000 [thread overview]
Message-ID: <a75605ef-3fe1-fdd0-d3da-b6421f932621@synopsys.com> (raw)
In-Reply-To: <87pmywnjxy.fsf@kernel.org>
Felipe Balbi wrote:
>
> Hi,
>
> Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>> The programming guide incorrectly stated that the DCFG.bInterval_m1 must
>> be set to 0 when operating in fullspeed. There's no such limitation for
>> all IPs.
>
> do we have an updated Databook correcting this statement?
Not yet. We're in the process of updating the databook for this
particular issue.
>
>> Cc: <stable@vger.kernel.org>
>> Fixes: a1679af85b2a ("usb: dwc3: gadget: Fix setting of DEPCFG.bInterval_m1")
>> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
>> ---
>> drivers/usb/dwc3/gadget.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
>> index 6227641f2d31..d87a29bd7d9b 100644
>> --- a/drivers/usb/dwc3/gadget.c
>> +++ b/drivers/usb/dwc3/gadget.c
>> @@ -608,12 +608,13 @@ static int dwc3_gadget_set_ep_config(struct dwc3_ep *dep, unsigned int action)
>> u8 bInterval_m1;
>>
>> /*
>> - * Valid range for DEPCFG.bInterval_m1 is from 0 to 13, and it
>> - * must be set to 0 when the controller operates in full-speed.
>> + * Valid range for DEPCFG.bInterval_m1 is from 0 to 13.
>> + *
>> + * NOTE: The programming guide incorrectly stated bInterval_m1
>> + * must be set to 0 when operating in fullspeed. Internally the
>> + * controller does not have this limitation.
>
> might be a good idea to refer to the section in this comment ;-)
>
I can resend with the section number.
BR,
Thinh
next prev parent reply other threads:[~2021-04-15 7:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 0:40 [PATCH] usb: dwc3: gadget: Remove FS bInterval_m1 limitation Thinh Nguyen
2021-04-15 6:25 ` Felipe Balbi
2021-04-15 7:10 ` Thinh Nguyen [this message]
2021-04-15 7:41 ` [PATCH v2] " Thinh Nguyen
2021-04-15 10:45 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a75605ef-3fe1-fdd0-d3da-b6421f932621@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=John.Youn@synopsys.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.