From: Julien Grall <julien@xen.org>
To: Oleksii Kurochko <oleksii.kurochko@gmail.com>,
xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Gianluca Guida <gianluca@rivosinc.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>,
Bobby Eshleman <bobby.eshleman@gmail.com>
Subject: Re: [PATCH v2 07/14] xen/riscv: introduce exception context
Date: Fri, 27 Jan 2023 14:54:24 +0000 [thread overview]
Message-ID: <a8219b2d-a22d-63ac-5088-c33610310d6e@xen.org> (raw)
In-Reply-To: <652289358975cf869e4bc0a6a70e3aba7bd2fbf6.1674818705.git.oleksii.kurochko@gmail.com>
Hi Oleksii,
On 27/01/2023 13:59, Oleksii Kurochko wrote:
> +static inline void wfi(void)
> +{
> + __asm__ __volatile__ ("wfi");
I have starred at this line for a while and I am not quite too sure to
understand why we don't need to clobber the memory like we do on Arm.
FWIW, Linux is doing the same, so I guess this is correct. For Arm we
also follow the Linux implementation.
But I am wondering whether we are just too strict on Arm, RISCv compiler
offer a different guarantee, or you expect the user to be responsible to
prevent the compiler to do harmful optimization.
> +/*
> + * panic() isn't available at the moment so an infinite loop will be
> + * used temporarily.
> + * TODO: change it to panic()
> + */
> +static inline void die(void)
> +{
> + for( ;; ) wfi();
Please move wfi() to a newline.
> +}
--
Julien Grall
next prev parent reply other threads:[~2023-01-27 14:54 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 13:59 [PATCH v2 00/14] RISCV basic exception handling implementation Oleksii Kurochko
2023-01-27 13:59 ` [PATCH v2 01/14] xen/riscv: add _zicsr to CFLAGS Oleksii Kurochko
2023-01-31 0:21 ` Alistair Francis
2023-01-31 9:14 ` Jan Beulich
2023-02-06 16:09 ` Oleksii
2023-01-27 13:59 ` [PATCH v2 02/14] xen/riscv: add <asm/asm.h> header Oleksii Kurochko
2023-01-31 0:49 ` Alistair Francis
2023-02-06 16:22 ` Oleksii
2023-01-27 13:59 ` [PATCH v2 03/14] xen/riscv: add <asm/riscv_encoding.h header Oleksii Kurochko
2023-01-30 13:29 ` Alistair Francis
2023-01-27 13:59 ` [PATCH v2 04/14] xen/riscv: add <asm/csr.h> header Oleksii Kurochko
2023-01-27 14:10 ` Jan Beulich
2023-01-30 11:37 ` Oleksii
2023-01-30 13:26 ` Alistair Francis
2023-01-27 13:59 ` [PATCH v2 05/14] xen/riscv: introduce empty <asm/string.h> Oleksii Kurochko
2023-01-31 0:49 ` Alistair Francis
2023-01-27 13:59 ` [PATCH v2 06/14] xen/riscv: introduce empty <asm/cache.h> Oleksii Kurochko
2023-01-31 0:50 ` Alistair Francis
2023-01-27 13:59 ` [PATCH v2 07/14] xen/riscv: introduce exception context Oleksii Kurochko
2023-01-27 14:24 ` Jan Beulich
2023-01-30 11:54 ` Oleksii
2023-01-30 13:50 ` Jan Beulich
2023-01-30 22:44 ` Julien Grall
2023-02-01 2:27 ` Andrew Cooper
2023-02-01 1:30 ` Stefano Stabellini
2023-02-06 17:13 ` Oleksii
2023-01-27 14:54 ` Julien Grall [this message]
2023-01-30 11:40 ` Oleksii
2023-01-30 22:11 ` Julien Grall
2023-01-31 12:24 ` Oleksii
2023-01-31 12:39 ` Julien Grall
2023-01-27 13:59 ` [PATCH v2 08/14] xen/riscv: introduce exception handlers implementation Oleksii Kurochko
2023-01-27 13:59 ` [PATCH v2 09/14] xen/riscv: introduce decode_cause() stuff Oleksii Kurochko
2023-01-27 13:59 ` [PATCH v2 10/14] xen/riscv: mask all interrupts Oleksii Kurochko
2023-01-27 13:59 ` [PATCH v2 11/14] xen/riscv: introduce trap_init() Oleksii Kurochko
2023-01-27 13:59 ` [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from <asm/bug.h> Oleksii Kurochko
2023-01-27 14:34 ` Jan Beulich
2023-01-30 11:23 ` Oleksii
2023-01-27 14:38 ` Jan Beulich
2023-01-27 16:02 ` Julien Grall
2023-01-30 11:35 ` Oleksii
2023-01-30 11:49 ` Juergen Gross
2023-01-30 22:28 ` Julien Grall
2023-01-31 12:34 ` Oleksii
2023-02-01 17:40 ` Oleksii
2023-02-01 22:11 ` Julien Grall
2023-02-02 11:50 ` Jan Beulich
2023-02-03 13:15 ` Oleksii
2023-02-03 13:23 ` Julien Grall
2023-02-03 16:25 ` Oleksii
2023-01-27 13:59 ` [PATCH v2 13/14] xen/riscv: test basic handling stuff Oleksii Kurochko
2023-01-27 13:59 ` [PATCH v2 14/14] automation: add smoke test to verify macros from bug.h Oleksii Kurochko
2023-01-27 14:43 ` Michal Orzel
2023-01-30 11:15 ` Oleksii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8219b2d-a22d-63ac-5088-c33610310d6e@xen.org \
--to=julien@xen.org \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobby.eshleman@gmail.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=gianluca@rivosinc.com \
--cc=jbeulich@suse.com \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.