From: Thomas Zimmermann <tzimmermann@suse.de>
To: Eric Anholt <eric@anholt.net>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v4 18/22] drm/vc4: Convert to CRTC VBLANK callbacks
Date: Mon, 10 Feb 2020 09:18:30 +0100 [thread overview]
Message-ID: <a874c4c9-c308-372d-4127-f2f1e2666317@suse.de> (raw)
In-Reply-To: <CADaigPXhkzHpXhrbb_A-uLmAjkXReXhbqmZ3yta9CUnBhSp_ig@mail.gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1950 bytes --]
adding dri-devel
Am 04.02.20 um 20:17 schrieb Eric Anholt:
> vc4 changes are:
>
> Acked-by: Eric Anholt <eric@anholt.net>
>
> On Thu, Jan 23, 2020 at 6:00 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>>
>> VBLANK callbacks in struct drm_driver are deprecated in favor of
>> their equivalents in struct drm_crtc_funcs. Convert vc4 over.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/vc4/vc4_crtc.c | 1 +
>> drivers/gpu/drm/vc4/vc4_drv.c | 2 --
>> 2 files changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
>> index f1e7597ea17e..1208258ad3b2 100644
>> --- a/drivers/gpu/drm/vc4/vc4_crtc.c
>> +++ b/drivers/gpu/drm/vc4/vc4_crtc.c
>> @@ -1031,6 +1031,7 @@ static const struct drm_crtc_funcs vc4_crtc_funcs = {
>> .gamma_set = drm_atomic_helper_legacy_gamma_set,
>> .enable_vblank = vc4_enable_vblank,
>> .disable_vblank = vc4_disable_vblank,
>> + .get_vblank_timestamp = drm_crtc_vblank_helper_get_vblank_timestamp,
>> };
>>
>> static const struct drm_crtc_helper_funcs vc4_crtc_helper_funcs = {
>> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
>> index e6982a7b0c5e..76f93b662766 100644
>> --- a/drivers/gpu/drm/vc4/vc4_drv.c
>> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
>> @@ -190,8 +190,6 @@ static struct drm_driver vc4_drm_driver = {
>> .irq_postinstall = vc4_irq_postinstall,
>> .irq_uninstall = vc4_irq_uninstall,
>>
>> - .get_vblank_timestamp = drm_calc_vbltimestamp_from_scanoutpos,
>> -
>> #if defined(CONFIG_DEBUG_FS)
>> .debugfs_init = vc4_debugfs_init,
>> #endif
>> --
>> 2.24.1
>>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-10 8:18 UTC|newest]
Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 13:59 [PATCH v4 00/22] drm: Clean up VBLANK callbacks in struct drm_driver Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 01/22] drm: Remove internal setup of struct drm_device.vblank_disable_immediate Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 02/22] drm: Add get_scanout_position() to struct drm_crtc_helper_funcs Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-03-02 21:55 ` Daniel Vetter
2020-03-02 21:55 ` Daniel Vetter
2020-03-02 21:55 ` [Intel-gfx] " Daniel Vetter
2020-03-02 21:55 ` Daniel Vetter
2020-03-02 21:55 ` Daniel Vetter
2020-01-23 13:59 ` [PATCH v4 03/22] drm: Add get_vblank_timestamp() to struct drm_crtc_funcs Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 04/22] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position() Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-02-03 20:41 ` Alex Deucher
2020-02-03 20:41 ` Alex Deucher
2020-02-03 20:41 ` [Intel-gfx] " Alex Deucher
2020-02-03 20:41 ` Alex Deucher
2020-02-03 20:41 ` Alex Deucher
2020-01-23 13:59 ` [PATCH v4 05/22] drm/amdgpu: Convert to CRTC VBLANK callbacks Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-02-03 20:42 ` Alex Deucher
2020-02-03 20:42 ` Alex Deucher
2020-02-03 20:42 ` [Intel-gfx] " Alex Deucher
2020-02-03 20:42 ` Alex Deucher
2020-02-03 20:42 ` Alex Deucher
2020-01-23 13:59 ` [PATCH v4 06/22] drm/gma500: " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 07/22] drm/i915: " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 08/22] drm/nouveau: Convert to struct drm_crtc_helper_funcs.get_scanout_position() Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-29 8:25 ` Ben Skeggs
2020-01-29 8:25 ` Ben Skeggs
2020-01-29 8:25 ` [Intel-gfx] " Ben Skeggs
2020-01-29 8:25 ` Ben Skeggs
2020-01-29 8:25 ` Ben Skeggs
2020-01-23 13:59 ` [PATCH v4 09/22] drm/nouveau: Convert to CRTC VBLANK callbacks Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-29 8:25 ` Ben Skeggs
2020-01-29 8:25 ` Ben Skeggs
2020-01-29 8:25 ` [Intel-gfx] " Ben Skeggs
2020-01-29 8:25 ` Ben Skeggs
2020-01-29 8:25 ` Ben Skeggs
2020-01-23 13:59 ` [PATCH v4 10/22] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position() Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-02-03 20:39 ` Alex Deucher
2020-02-03 20:39 ` Alex Deucher
2020-02-03 20:39 ` [Intel-gfx] " Alex Deucher
2020-02-03 20:39 ` Alex Deucher
2020-02-03 20:39 ` Alex Deucher
2020-01-23 13:59 ` [PATCH v4 11/22] drm/radeon: Convert to CRTC VBLANK callbacks Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 12/22] drm/msm: Convert to struct drm_crtc_helper_funcs.get_scanout_position() Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 13/22] drm/msm: Convert to CRTC VBLANK callbacks Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 14/22] drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position() Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-24 10:42 ` Philippe CORNU
2020-01-24 10:42 ` Philippe CORNU
2020-01-24 10:42 ` [Intel-gfx] " Philippe CORNU
2020-01-24 10:42 ` Philippe CORNU
2020-01-24 10:42 ` Philippe CORNU
2020-01-23 13:59 ` [PATCH v4 15/22] drm/stm: Convert to CRTC VBLANK callbacks Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-24 10:43 ` Philippe CORNU
2020-01-24 10:43 ` Philippe CORNU
2020-01-24 10:43 ` [Intel-gfx] " Philippe CORNU
2020-01-24 10:43 ` Philippe CORNU
2020-01-24 10:43 ` Philippe CORNU
2020-01-23 13:59 ` [PATCH v4 16/22] drm/sti: " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 17/22] drm/vc4: Convert to struct drm_crtc_helper_funcs.get_scanout_position() Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 18/22] drm/vc4: Convert to CRTC VBLANK callbacks Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
[not found] ` <CADaigPXhkzHpXhrbb_A-uLmAjkXReXhbqmZ3yta9CUnBhSp_ig@mail.gmail.com>
2020-02-10 8:18 ` Thomas Zimmermann [this message]
2020-01-23 13:59 ` [PATCH v4 19/22] drm/vkms: " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 20/22] drm/vmwgfx: " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 21/22] drm: Clean-up VBLANK-related callbacks in struct drm_driver Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [PATCH v4 22/22] drm: Remove legacy version of get_scanout_position() Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 13:59 ` [Intel-gfx] " Thomas Zimmermann
2020-01-23 13:59 ` Thomas Zimmermann
2020-01-23 22:55 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: Clean up VBLANK callbacks in struct drm_driver (rev9) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a874c4c9-c308-372d-4127-f2f1e2666317@suse.de \
--to=tzimmermann@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.