From: zhaogongyi <zhaogongyi@huawei.com>
To: David Hildenbrand <david@redhat.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Cc: "akinobu.mita@gmail.com" <akinobu.mita@gmail.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"osalvador@suse.de" <osalvador@suse.de>,
"shuah@kernel.org" <shuah@kernel.org>
Subject: Re: [PATCH -next 4/5] selftests/memory-hotplug: Restore memory before exit
Date: Thu, 15 Sep 2022 09:07:13 +0000 [thread overview]
Message-ID: <a87ac52f279b4bc3944c57f135d8c03c@huawei.com> (raw)
Hi,
Thanks for your review, I have submit the patches in a new version as your suggestion.
Best Wishes,
Gongyi
>
> On 09.09.22 09:51, Zhao Gongyi wrote:
> > Some momory will be left in offline state when calling
> > offline_memory_expect_fail() failed. Restore it before exit.
> >
> > Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> > ---
> > .../memory-hotplug/mem-on-off-test.sh | 24
> +++++++++++++------
> > 1 file changed, 17 insertions(+), 7 deletions(-)
> >
> > diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> > b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> > index 3bdf3c4d6d06..259fd8978639 100755
> > --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> > +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> > @@ -134,6 +134,17 @@ offline_memory_expect_fail()
> > return 0
> > }
> >
> > +online_all_hot_pluggable_memory()
> > +{
> > +
> > + for memory in `hotpluggable_offline_memory`; do
> > + online_memory_expect_success $memory || {
> > + echo "online memory $memory: unexpected fail"
> > + retval=1
> > + }
> > + done
> > +}
>
> Maybe call it
>
> "online_all_offline_memory()"
>
> instead?
>
> Note that "removable" as used in hotpluggable_memory() will nowadays
> always return "1" if the kernel supports memory hotunplug, independent
> of the specific memory block.
>
> --
> Thanks,
>
> David / dhildenb
next reply other threads:[~2022-09-15 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 9:07 zhaogongyi [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-09 7:51 [PATCH -next 0/5] Optimize and bugfix for notifier error Zhao Gongyi
2022-09-09 7:51 ` [PATCH -next 4/5] selftests/memory-hotplug: Restore memory before exit Zhao Gongyi
2022-09-09 12:21 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a87ac52f279b4bc3944c57f135d8c03c@huawei.com \
--to=zhaogongyi@huawei.com \
--cc=akinobu.mita@gmail.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.